Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4729662018158592: Issue #735 Add platform field and restrict component access in the issue tracker. (Closed)

Created:
July 1, 2014, 10:02 a.m. by Philip Hill
Modified:
July 1, 2014, 12:51 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue #735 Add platform field and restrict component access in the issue tracker.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed "All" choice. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M modules/trac/templates/trac.ini.erb View 1 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4
Philip Hill
July 1, 2014, 10:03 a.m. (2014-07-01 10:03:02 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4729662018158592/diff/5629499534213120/modules/trac/templates/trac.ini.erb File modules/trac/templates/trac.ini.erb (right): http://codereview.adblockplus.org/4729662018158592/diff/5629499534213120/modules/trac/templates/trac.ini.erb#newcode330 modules/trac/templates/trac.ini.erb:330: platform.value = Unknown Do you think we should really ...
July 1, 2014, 11:22 a.m. (2014-07-01 11:22:47 UTC) #2
Philip Hill
July 1, 2014, 11:57 a.m. (2014-07-01 11:57:56 UTC) #3
Wladimir Palant
July 1, 2014, 12:44 p.m. (2014-07-01 12:44:55 UTC) #4
LGTM

As discussed, we still need Unknown for infrastructure changes for example.

Powered by Google App Engine
This is Rietveld