Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4834063596650496: Issue #1185 - Formatting for sources in 'installer-ca' (Closed)

Created:
May 19, 2015, 11:04 p.m. by Eric
Modified:
Oct. 13, 2015, 7:22 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1185 - Formatting for sources in 'installer-ca' Update formatting for the two source files in the project 'installer-ca'.

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -252 lines) Patch
M installer/src/custom-action/abp_ca.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M installer/src/custom-action/close_application.cpp View 1 4 chunks +242 lines, -247 lines 0 comments Download

Messages

Total messages: 4
Eric
May 19, 2015, 11:06 p.m. (2015-05-19 23:06:19 UTC) #1
Eric
Issue #1185 is a P2 issue. This review was posted a week shy of five ...
Oct. 9, 2015, 4:23 p.m. (2015-10-09 16:23:17 UTC) #2
Oleksandr
LGTM with one nit. https://codereview.adblockplus.org/4834063596650496/diff/5629499534213120/installer/src/custom-action/close_application.cpp File installer/src/custom-action/close_application.cpp (right): https://codereview.adblockplus.org/4834063596650496/diff/5629499534213120/installer/src/custom-action/close_application.cpp#newcode231 installer/src/custom-action/close_application.cpp:231: // Assert state is one ...
Oct. 11, 2015, 4:13 p.m. (2015-10-11 16:13:12 UTC) #3
Eric
Oct. 13, 2015, 7:18 p.m. (2015-10-13 19:18:35 UTC) #4
Posted patch set as committed. Delta between patch set 1 and 2 includes changes
from rebasing.

Powered by Google App Engine
This is Rietveld