Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4865011998523392: Change ssh keys to ecdsa (Closed)

Created:
Nov. 18, 2013, 4:17 p.m. by christian
Modified:
Nov. 19, 2013, 7:03 a.m.
Visibility:
Public.

Description

Change ssh keys to ecdsa

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revert the changes to filterserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -32 lines) Patch
M modules/filtermaster/manifests/init.pp View 1 chunk +3 lines, -2 lines 0 comments Download
M modules/filterserver/manifests/init.pp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M modules/private-stub/files/filtermaster.adblockplus.org_ssh.key View 1 chunk +5 lines, -27 lines 0 comments Download
M modules/private-stub/files/filtermaster.adblockplus.org_ssh.pub View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
christian
Nov. 18, 2013, 4:18 p.m. (2013-11-18 16:18:51 UTC) #1
Felix Dahlke
LGTM for the SSH key changes - although I don't really see the reasoning behind ...
Nov. 18, 2013, 4:29 p.m. (2013-11-18 16:29:22 UTC) #2
Wladimir Palant
On 2013/11/18 16:29:22, Felix H. Dahlke wrote: > I'm not so sure about the CheckHostIP ...
Nov. 18, 2013, 5:20 p.m. (2013-11-18 17:20:37 UTC) #3
Felix Dahlke
I get it, then this is related and LGTM.
Nov. 18, 2013, 5:21 p.m. (2013-11-18 17:21:21 UTC) #4
Wladimir Palant
LGTM if the key change on filter servers is reverted. http://codereview.adblockplus.org/4865011998523392/diff/5629499534213120/modules/filterserver/manifests/init.pp File modules/filterserver/manifests/init.pp (right): http://codereview.adblockplus.org/4865011998523392/diff/5629499534213120/modules/filterserver/manifests/init.pp#newcode105 ...
Nov. 18, 2013, 5:36 p.m. (2013-11-18 17:36:23 UTC) #5
christian
Revert Changes to filterserver
Nov. 18, 2013, 6:07 p.m. (2013-11-18 18:07:27 UTC) #6
Felix Dahlke
Nov. 19, 2013, 6:05 a.m. (2013-11-19 06:05:50 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld