Issue 2384 - Remove Firefox/Mozilla references on about:firefox

Issue 2384 - Remove Firefox/Mozilla references on about:firefox

[René Jeschke, 2015-05-06 19:32:43]

Here's how it looks:

https://www.dropbox.com/s/lqqj0n6jtgdqg0m/abb_about.png?dl=0

[Felix Dahlke, 2015-05-06 20:35:06]

In general I'm not completely happy with putting our custom stuff into
mobile/android/chrome - shouldn't be too hard to use a different folder and just
register whatever Chrome URL we want to use, then just modify the redirector.
But it's OK as it is.

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
File mobile/android/app/mobile.js (right):

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
mobile/android/app/mobile.js:487: pref("app.privacyURL",
"https://adblockplus.org/en/privacy-policy");
Assuming this is not used anywhere else - why not just hard code the URLs in
aboutAdblockBrowser.xhtml? Less intrusive , and this file is not localised
anyway.

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
File mobile/android/chrome/content/aboutAdblockBrowser.xhtml (right):

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
mobile/android/chrome/content/aboutAdblockBrowser.xhtml:20: <link
rel="stylesheet" href="chrome://browser/skin/aboutAdblockBrowserPage.css"
type="text/css"/>
Nit: I guess I'd call it aboutPageAdblockBrowser.css so it looks more similar.

[René Jeschke, 2015-05-06 21:45:00]

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
File mobile/android/app/mobile.js (right):

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
mobile/android/app/mobile.js:487: pref("app.privacyURL",
"https://adblockplus.org/en/privacy-policy");
On 2015/05/06 20:35:07, Felix H. Dahlke wrote:
> Assuming this is not used anywhere else - why not just hard code the URLs in
> aboutAdblockBrowser.xhtml? Less intrusive , and this file is not localised
> anyway.

For now, we need to add localisation later anyways.

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
File mobile/android/chrome/content/aboutAdblockBrowser.xhtml (right):

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
mobile/android/chrome/content/aboutAdblockBrowser.xhtml:20: <link
rel="stylesheet" href="chrome://browser/skin/aboutAdblockBrowserPage.css"
type="text/css"/>
On 2015/05/06 20:35:07, Felix H. Dahlke wrote:
> Nit: I guess I'd call it aboutPageAdblockBrowser.css so it looks more similar.

Too late to argue about this, though the name does not make sense :D

[Felix Dahlke, 2015-05-06 21:48:47]

LGTM!

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
File mobile/android/chrome/content/aboutAdblockBrowser.xhtml (right):

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
mobile/android/chrome/content/aboutAdblockBrowser.xhtml:20: <link
rel="stylesheet" href="chrome://browser/skin/aboutAdblockBrowserPage.css"
type="text/css"/>
On 2015/05/06 21:45:00, René Jeschke wrote:
> On 2015/05/06 20:35:07, Felix H. Dahlke wrote:
> > Nit: I guess I'd call it aboutPageAdblockBrowser.css so it looks more
similar.
> 
> Too late to argue about this, though the name does not make sense :D

:D