Issue 4946299447148544: Issue 1761 - services page on Eyeo.com (Closed)
|
Created:
March 10, 2015, 12:55 p.m. by saroyanm Modified:
May 12, 2015, 9:47 a.m. Reviewers:
Thomas Greiner CC:
Felix Dahlke Visibility:
Public. |
DescriptionRelated ticket:
https://issues.adblockplus.org/ticket/1761
Patch Set 1 #Patch Set 2 : changed .raw to .html #
Total comments: 34
Patch Set 3 : ad-networks renamed to ad-network #Patch Set 4 : Adressed comments initial Thomas comments (bunch of grammar and TYPO fixes) #
Total comments: 8
Patch Set 5 : Small text fixes #Patch Set 6 : Acceptable Ads text concretisation #
MessagesTotal messages: 10
Thomas can you please have a look when you have time, The changes are not that big, mostly taken from Already existing Press page. I've just modified the tabs to change according to react on fragment identifier changes, Currently solution we have in eyeo.com looks ugly, but I think we should modify whole website in future.
On 2015/03/10 13:30:47, saroyanm wrote: > Thomas can you please have a look when you have time, > > The changes are not that big, mostly taken from Already existing Press page. > > I've just modified the tabs to change according to react on fragment identifier > changes, > > Currently solution we have in http://eyeo.com looks ugly, but I think we should modify > whole website in future. The patch is updated.
It'd be great if we could make the text column of the services page narrower (similar to the center column on the press page) because it does hurt legibility and it makes it look a bit unprofessional IMHO. Nearly all of the comments are about issues with the provided text from the issue description. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/ad-networks.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:1: Want to work with us hand-in-hand to develop the advertising landscape of the future? Join the acceptable ads program and add your ads to the Whitelist. Working to develop non-intrusive ads for users that are a choosy, tech-savvy audience is the long-term benefit. "acceptable ads" should be upper-case. Note that we also mention on eyeo.com that "Acceptable Ads" is a registered trademark. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:3: Ad networks can become a member of our Acceptable Ads program, and get their Acceptable Ads certified. There are two spaces between "their" and "Acceptable" http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:5: Among other things we can help you define standard design templates for your advertisers in the first step. Then we assist you in setting up the technical environment necessary for working with multiple publishers and hundreds of websites. There are two spaces between "can" and "help" http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:9: Keep in mind that we will check your ads against the Acceptable Ads criteria. These criteria were developed with our users, and in order to participate in Acceptable Ads the ads in question must be in line with them. During your application we will also mutually determine the level of required support services. What about making a link to the criteria out of "Acceptable Ads criteria"? (see also advertiser.md and publisher.md) http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/ad-tech.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-tech.md:5: [Contact us](https://eyeo.com/en/contact) if you want to learn more. On each other page we say "Please contact us". Why is it different here? http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/overview.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filterlist that can be added to Eyeo´s open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. I know we're quite inconsistent regarding whether to write "filterlist" or "filter list" but in all the original documentation on our website we say "filter list" so I'd suggest applying that here as well. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filterlist that can be added to Eyeo´s open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. Make sure that exotic characters such as in "Eyeo´s" are replaced with "Eyeo's" http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/publisher.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: Replace "AdBlock Plus" with "Adblock Plus" http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: "publishers … its advertising" is incorrect. It should be "their advertising". http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: There are two occurences of two consecutive full stops in this paragraph. One is more than sufficient to make a point. ;) (pun intended) http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: There should be no space before a comma http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: "shown to him" needs to be gender-neutral. Either turn "user" into "users" so that you can say "they" or say "him or her". http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: "Whitelist" should be lower-case for consistency http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: I don't see a reason for the colon to be at the end of the paragraph http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... File pages/services.html (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... pages/services.html:18: jQuery(window).on("hashchange", function() This feature wasn't mentioned in the issue so no need to include it. Note that it also makes the page jump when clicking on links. That means that the following code (which can also be found on other pages already) should be sufficient: jQuery(function() { jQuery("#tabs").tabs(); }); http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... pages/services.html:29: <div id="press-info" class="content-block"> I assume that this is a copy&paste issue so please replace "press-info" with "services-info". Note that the "id" attribute is not required here so you can remove it unless there's a reason I'm not aware of. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... pages/services.html:36: <li><a href="#ad-networks">Ad Networks</a></li> Interestingly, the names of the other tabs are singular. Unless there's a reason to make an exception for ad networks, this can be made singular as well (not only the name but also element IDs and file names).
Patch Set 2 : changed .raw to .html Thanks for the comments Thomas, I'll align regarding "making text column of the services page narrower" with Sven and update it, because what I can see so far the page looks ugly in both cases, would really be nice to have left column somehow IMO. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/ad-networks.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:1: Want to work with us hand-in-hand to develop the advertising landscape of the future? Join the acceptable ads program and add your ads to the Whitelist. Working to develop non-intrusive ads for users that are a choosy, tech-savvy audience is the long-term benefit. On 2015/04/14 17:31:35, Thomas Greiner wrote: > "acceptable ads" should be upper-case. Note that we also mention on http://eyeo.com > that "Acceptable Ads" is a registered trademark. Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:3: Ad networks can become a member of our Acceptable Ads program, and get their Acceptable Ads certified. On 2015/04/14 17:31:35, Thomas Greiner wrote: > There are two spaces between "their" and "Acceptable" Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:5: Among other things we can help you define standard design templates for your advertisers in the first step. Then we assist you in setting up the technical environment necessary for working with multiple publishers and hundreds of websites. On 2015/04/14 17:31:35, Thomas Greiner wrote: > There are two spaces between "can" and "help" Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-networks.md:9: Keep in mind that we will check your ads against the Acceptable Ads criteria. These criteria were developed with our users, and in order to participate in Acceptable Ads the ads in question must be in line with them. During your application we will also mutually determine the level of required support services. On 2015/04/14 17:31:35, Thomas Greiner wrote: > What about making a link to the criteria out of "Acceptable Ads criteria"? (see > also advertiser.md and publisher.md) Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/ad-tech.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/ad-tech.md:5: [Contact us](https://eyeo.com/en/contact) if you want to learn more. On 2015/04/14 17:31:35, Thomas Greiner wrote: > On each other page we say "Please contact us". Why is it different here? Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/overview.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filterlist that can be added to Eyeo´s open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. On 2015/04/14 17:31:35, Thomas Greiner wrote: > I know we're quite inconsistent regarding whether to write "filterlist" or > "filter list" but in all the original documentation on our website we say > "filter list" so I'd suggest applying that here as well. Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filterlist that can be added to Eyeo´s open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. On 2015/04/14 17:31:35, Thomas Greiner wrote: > Make sure that exotic characters such as in "Eyeo´s" are replaced with "Eyeo's" Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... File includes/services/publisher.md (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: On 2015/04/14 17:31:35, Thomas Greiner wrote: > Replace "AdBlock Plus" with "Adblock Plus" Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: On 2015/04/14 17:31:35, Thomas Greiner wrote: > "publishers … its advertising" is incorrect. It should be "their advertising". Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: On 2015/04/14 17:31:35, Thomas Greiner wrote: > There are two occurences of two consecutive full stops in this paragraph. One is > more than sufficient to make a point. ;) (pun intended) Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: On 2015/04/14 17:31:35, Thomas Greiner wrote: > There should be no space before a comma Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: On 2015/04/14 17:31:35, Thomas Greiner wrote: > "shown to him" needs to be gender-neutral. Either turn "user" into "users" so > that you can say "they" or say "him or her". Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: On 2015/04/14 17:31:35, Thomas Greiner wrote: > "Whitelist" should be lower-case for consistency Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. . While there are many ways for them to achieve this, AdBlock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust its advertising to a level that is again acceptable to such users when they visit your websites.. When acceptable ads are enabled by the Adblock Plus user , certain forms of advertising will be shown to him if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the Whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted: On 2015/04/14 17:31:35, Thomas Greiner wrote: > I don't see a reason for the colon to be at the end of the paragraph Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... File pages/services.html (right): http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... pages/services.html:18: jQuery(window).on("hashchange", function() On 2015/04/14 17:31:35, Thomas Greiner wrote: > This feature wasn't mentioned in the issue so no need to include it. Note that > it also makes the page jump when clicking on links. > > That means that the following code (which can also be found on other pages > already) should be sufficient: > > jQuery(function() > { > jQuery("#tabs").tabs(); > }); Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... pages/services.html:29: <div id="press-info" class="content-block"> On 2015/04/14 17:31:35, Thomas Greiner wrote: > I assume that this is a copy&paste issue so please replace "press-info" with > "services-info". > > Note that the "id" attribute is not required here so you can remove it unless > there's a reason I'm not aware of. Done. http://codereview.adblockplus.org/4946299447148544/diff/5685265389584384/page... pages/services.html:36: <li><a href="#ad-networks">Ad Networks</a></li> On 2015/04/14 17:31:35, Thomas Greiner wrote: > Interestingly, the names of the other tabs are singular. Unless there's a reason > to make an exception for ad networks, this can be made singular as well (not > only the name but also element IDs and file names). Done.
On 2015/04/14 17:31:35, Thomas Greiner wrote: > It'd be great if we could make the text column of the services page narrower > (similar to the center column on the press page) because it does hurt legibility > and it makes it look a bit unprofessional IMHO. According to the current comment -> https://issues.adblockplus.org/ticket/1761#comment:17 We can give a go with current version for now I think.
http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/ad-network.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/ad-network.md:1: Want to work with us hand-in-hand to develop the advertising landscape of the future? Join the Acceptable Ads program and add your ads to the Whitelist. Working to develop non-intrusive ads for users that are a choosy, tech-savvy audience is the long-term benefit. Make "Whitelist" lower-case http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/overview.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filter list that can be added to Eyeo's open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. "which can be added to Eyeo's open source software Adblock Plus" It's added by default so that statement is somewhat misleading. Please check back with Christian on that. http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/publisher.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. While there are many ways for them to achieve this, Adblock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust their advertising to a level that is again acceptable to such users when they visit your websites. When acceptable ads are enabled by the Adblock Plus users, certain forms of advertising will be shown to them if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted. "if they comply" is ambiguous now (it could refer either to "users" or "forms of advertising". So I'd replace it with "if the ads comply".
Patch Set 5 : Small text fixes http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/ad-network.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/ad-network.md:1: Want to work with us hand-in-hand to develop the advertising landscape of the future? Join the Acceptable Ads program and add your ads to the Whitelist. Working to develop non-intrusive ads for users that are a choosy, tech-savvy audience is the long-term benefit. On 2015/05/11 10:00:10, Thomas Greiner wrote: > Make "Whitelist" lower-case Done. http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/overview.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filter list that can be added to Eyeo's open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. On 2015/05/11 10:00:10, Thomas Greiner wrote: > "which can be added to Eyeo's open source software Adblock Plus" > > It's added by default so that statement is somewhat misleading. Please check > back with Christian on that. Done. http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/publisher.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/publisher.md:1: As a publisher you might recognize a difference between page impressions and ad impressions on your website. This could be a result of visitors to your website that rejected to see your ads due to privacy or other concerns. While there are many ways for them to achieve this, Adblock Plus is the only solution that offers its users an optional predefined whitelist and equally publishers a way to dynamically adjust their advertising to a level that is again acceptable to such users when they visit your websites. When acceptable ads are enabled by the Adblock Plus users, certain forms of advertising will be shown to them if they comply with the strict Acceptable Ads criteria. Such ads need to be manually added to the whitelist by Eyeo as there is no automatic way to review that. As a publisher you might want to apply to get whitelisted. On 2015/05/11 10:00:10, Thomas Greiner wrote: > "if they comply" is ambiguous now (it could refer either to "users" or "forms of > advertising". So I'd replace it with "if the ads comply". Done.
http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/overview.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filter list that can be added to Eyeo's open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. On 2015/05/11 15:18:16, saroyanm wrote: > On 2015/05/11 10:00:10, Thomas Greiner wrote: > > "which can be added to Eyeo's open source software Adblock Plus" > > > > It's added by default so that statement is somewhat misleading. Please check > > back with Christian on that. > > Done. Sorry for the confusion but that wasn't meant as a suggestion. I just inserted a shortened quote to refer to the relevant passage. My suggestion would be something like this: "which is an optional filter list that comes preinstalled with Eyeo's open source software Adblock Plus"
Patch Set 6 : Acceptable Ads text concretisation http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... File includes/services/overview.md (right): http://codereview.adblockplus.org/4946299447148544/diff/4769741570834432/incl... includes/services/overview.md:3: It also maintains the Acceptable Ads program, which is an optional predefined filter list that can be added to Eyeo's open source software [Adblock Plus](https://adblockplus.org/). Acceptable Ads allows users of Adblock Plus to unblock certified non-intrusive forms of advertising by default. On 2015/05/11 15:40:37, Thomas Greiner wrote: > On 2015/05/11 15:18:16, saroyanm wrote: > > On 2015/05/11 10:00:10, Thomas Greiner wrote: > > > "which can be added to Eyeo's open source software Adblock Plus" > > > > > > It's added by default so that statement is somewhat misleading. Please check > > > back with Christian on that. > > > > Done. > > Sorry for the confusion but that wasn't meant as a suggestion. I just inserted a > shortened quote to refer to the relevant passage. My suggestion would be > something like this: > > "which is an optional filter list that comes preinstalled with Eyeo's open > source software Adblock Plus" Sorry I also should undestood that and align back with you. Done.
LGTM 
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
