Issue 4998212691689472: Some click-hide improvements

Issue 4998212691689472: Some click-hide improvements (Closed)

Created:
Dec. 18, 2013, 10:13 a.m. by Wladimir Palant

Modified:
Dec. 18, 2013, 11:47 a.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Three issues fixed here: * Links can be followed in click/hide mode (makes blocking links harder). * Selecting an element is unnecessarily hard - if an element has none of ID/class/src we should look at its parent element. * The hotkey Ctrl-Shift-E isn't exactly well-known, Enter and Esc should be processed instead.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Also fixed key handler #

Total comments: 2

Created: Dec. 18, 2013, 10:58 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -47 lines)			Patch
	M	include.postload.js	View	1	6 chunks	+70 lines, -47 lines	2 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Thomas Greiner

LGTM with the comment addressed. http://codereview.adblockplus.org/4998212691689472/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4998212691689472/diff/5629499534213120/include.postload.js#newcode225 include.postload.js:225: if (target && target ...

Dec. 18, 2013, 10:32 a.m. (2013-12-18 10:32:54 UTC) #2

Wladimir Palant

Fixed that issue and also the hotkey handling.

Dec. 18, 2013, 11:01 a.m. (2013-12-18 11:01:38 UTC) #3

Thomas Greiner

http://codereview.adblockplus.org/4998212691689472/diff/5724160613416960/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4998212691689472/diff/5724160613416960/include.postload.js#newcode254 include.postload.js:254: if (!e.ctrlKey && !e.altKey && !e.shiftKey && e.keyCode == ...

Dec. 18, 2013, 11:17 a.m. (2013-12-18 11:17:12 UTC) #4

Wladimir Palant

Dec. 18, 2013, 11:39 a.m. (2013-12-18 11:39:57 UTC) #5

LGTM

Expand All Messages | Collapse All Messages