Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5077480096399360: Issue 112 - Production hosts.yaml (Closed)

Created:
March 17, 2015, 9:36 a.m. by mathias
Modified:
March 17, 2015, 11:12 a.m.
Reviewers:
Felix Dahlke
CC:
Wladimir Palant
Visibility:
Public.

Description

Note that some hosts are missing! web2 and whitelisting1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -0 lines) Patch
A hosts.yaml View 1 chunk +188 lines, -0 lines 0 comments Download

Messages

Total messages: 4
mathias
March 17, 2015, 9:36 a.m. (2015-03-17 09:36:31 UTC) #1
mathias
On 2015/03/17 09:36:31, matze wrote: Note that both web2 and whitelisting1 are not included here. ...
March 17, 2015, 9:39 a.m. (2015-03-17 09:39:37 UTC) #2
Felix Dahlke
On 2015/03/17 09:39:37, matze wrote: > On 2015/03/17 09:36:31, matze wrote: > > Note that ...
March 17, 2015, 9:40 a.m. (2015-03-17 09:40:54 UTC) #3
Felix Dahlke
March 17, 2015, 10:01 a.m. (2015-03-17 10:01:54 UTC) #4
LGTM

For the record: I think it's a bit hard to read and we should think about
reducing duplication (at this point only the SSH key how I see it) - but Matze
assured me he's working on this.

Powered by Google App Engine
This is Rietveld