Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5094040492048384: Build release versions by default (again) (Closed)

Created:
Feb. 27, 2014, 5:24 p.m. by Felix Dahlke
Modified:
March 4, 2014, 12:03 a.m.
Reviewers:
Wladimir Palant
CC:
Andrey Novikov
Visibility:
Public.

Description

This turned out to be why all the release users are on the devbuild now. So far I presumed that the release build process would set res/bools.xml:def_release to true, while in reality the devbuild build process sets it to false. Thus, def_release needs to be true by default, but it was (possibly accidentally) set to false here: https://hg.adblockplus.org/adblockplusandroid/rev/58a55e3b9974 So all this patch does is set it back to true. The next release we publish will actually consider itself a release build.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M res/values/bools.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Felix Dahlke
Feb. 27, 2014, 6:11 p.m. (2014-02-27 18:11:39 UTC) #1
Wladimir Palant
March 3, 2014, 7:41 a.m. (2014-03-03 07:41:37 UTC) #2
Ouch... LGTM

Powered by Google App Engine
This is Rietveld