Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5096167658487808: [IE] Dead code (Closed)

Created:
June 20, 2014, 9:26 p.m. by Eric
Modified:
July 18, 2014, 4:35 p.m.
Visibility:
Public.

Description

This review is for dead code found during the ATL work. I've separated it out into a separate review so that it can be applied sooner.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -209 lines) Patch
M src/plugin/PluginFilter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/plugin/PluginFilter.cpp View 2 chunks +0 lines, -154 lines 1 comment Download
M src/plugin/PluginSettings.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/plugin/PluginSystem.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/plugin/PluginSystem.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M src/plugin/PluginWbPassThrough.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
Eric
http://codereview.adblockplus.org/5096167658487808/diff/5629499534213120/src/plugin/PluginFilter.cpp File src/plugin/PluginFilter.cpp (left): http://codereview.adblockplus.org/5096167658487808/diff/5629499534213120/src/plugin/PluginFilter.cpp#oldcode721 src/plugin/PluginFilter.cpp:721: } The last function that called FindMatch() was replaced ...
June 20, 2014, 9:30 p.m. (2014-06-20 21:30:41 UTC) #1
Oleksandr
LGTM
July 11, 2014, 4:43 p.m. (2014-07-11 16:43:33 UTC) #2
Wladimir Palant
July 11, 2014, 7:40 p.m. (2014-07-11 19:40:13 UTC) #3
You probably want to add fhd as reviewer instead of me.

Powered by Google App Engine
This is Rietveld