Issue 5096952043667456: Fixed: Social widgets removed from share popup in first-run page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5096952043667456: Fixed: Social widgets removed from share popup in first-run page (Closed)

Created:
Nov. 14, 2013, 5:02 p.m. by Thomas Greiner

Modified:
Jan. 29, 2014, 12:07 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

This is not a fix for the underlying issue but merely an improvement that prevents the removal of elements on a page that are not supposed to be removed. The real issue is that under some circumstances we get an empty object back from the chrome.extension.sendRequest callback even though a boolean was sent by the background page. I was able to reproduce this semi-reliably by installing the extension, opening the share page from within the first-run page and/or visiting share.adblockplus.org in another tab - although I couldn't get it to work each time. As soon as the problem can be narrowed down enough we should either commit another fix and/or file an issue report if it turns out to be really Chromium related. FYI: The fact that chrome.extension.sendRequest/onRequest has been deprecated is not the source of this issue.

Patch Set 1 #

Created: Nov. 14, 2013, 5:02 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include.preload.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Cannot reproduce this issue anymore.

Expand All Messages | Collapse All Messages