Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/requestNotifier.js

Issue 5121479175831552: issue 47 - use WeakMap instead of setUserData and getUserData methods (Closed)
Patch Set: Created May 18, 2014, 12:48 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/requestNotifier.js
===================================================================
--- a/lib/requestNotifier.js
+++ b/lib/requestNotifier.js
@@ -29,10 +29,9 @@
let windowSelection = new WeakMap();
let setEntry, hasEntry, getEntry;
-if (false)
+// Last issue(Bug 982561) preventing us from using WeakMap fixed for FF version 32
+if (Services.vc.compare(Utils.platformVersion, "32.0a1") >= 0)
{
- // This branch can be enabled again once all of bug 673468, bug 819131 and
- // bug 982561 are fixed and we can use weak maps.
setEntry = function(map, key, value) map.set(key, value);
hasEntry = function(map, key) map.has(key);
getEntry = function(map, key) map.get(key);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld