Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5133042217648128: Add a README with build instructions (Closed)

Created:
March 5, 2014, 2:27 p.m. by Felix Dahlke
Modified:
March 5, 2014, 3:27 p.m.
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed Ant build instructions, added instructions for running #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A README.md View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Felix Dahlke
March 5, 2014, 2:27 p.m. (2014-03-05 14:27:55 UTC) #1
René Jeschke
http://codereview.adblockplus.org/5133042217648128/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5133042217648128/diff/5629499534213120/README.md#newcode25 README.md:25: ant build There is no 'build' target in the ...
March 5, 2014, 2:38 p.m. (2014-03-05 14:38:22 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5133042217648128/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5133042217648128/diff/5629499534213120/README.md#newcode13 README.md:13: - [Ant](http://ant.apache.org) Does the JDK count as a requirement? ...
March 5, 2014, 2:45 p.m. (2014-03-05 14:45:09 UTC) #3
Felix Dahlke
Fixed the Android build instructions and also added instructions for installing and running the app. ...
March 5, 2014, 2:47 p.m. (2014-03-05 14:47:57 UTC) #4
René Jeschke
LGTM
March 5, 2014, 2:53 p.m. (2014-03-05 14:53:55 UTC) #5
Wladimir Palant
March 5, 2014, 3:17 p.m. (2014-03-05 15:17:28 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld