Issue 5137878350823424: Unified filenames, removed unused files.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5137878350823424: Unified filenames, removed unused files. (Closed)

Created:
March 5, 2014, 1:24 p.m. by René Jeschke

Modified:
March 5, 2014, 2:54 p.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

- Renamed files to match ABP pattern - removed unused files from JNI/native code

Patch Set 1 #

Created: March 5, 2014, 1:24 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+580 lines, -1645 lines)			Patch
M	.hgignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	jni/AbpEngine.cpp	View	1 chunk	+558 lines, -0 lines	0 comments	Download
M	jni/Android.mk	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jni/AndroidWebRequest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	jni/Debug.h	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	jni/Utils.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
R	jni/abpEngine.cpp	View	1 chunk	+0 lines, -558 lines	0 comments	Download
R	jni/debug.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
R	jni/fileOps.cpp	View	1 chunk	+0 lines, -212 lines	0 comments	Download
R	jni/jsEngine.cpp	View	1 chunk	+0 lines, -280 lines	0 comments	Download
R	jni/ops.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
R	jni/timerOps.cpp	View	1 chunk	+0 lines, -100 lines	0 comments	Download
R	jni/utilityOps.cpp	View	1 chunk	+0 lines, -157 lines	0 comments	Download
R	jni/wrap.h	View	1 chunk	+0 lines, -24 lines	0 comments	Download
R	jni/wrap.cpp	View	1 chunk	+0 lines, -159 lines	0 comments	Download
R	jni/xhrOps.cpp	View	1 chunk	+0 lines, -93 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

March 5, 2014, 2:50 p.m. (2014-03-05 14:50:56 UTC) #3

LGTM assuming that adding jni/.* to .hgignore somehow makes sense and that the
files were properly renamed rather than removed and then re-added under a new
name (not really clear with Rietveld unfortunately).

Expand All Messages | Collapse All Messages