Issue #1234 - Remove CString from ShouldBlock(), IsElementHidden() declarations

Issue #1234 - Remove CString from ShouldBlock(), IsElementHidden() declarations

Changed from CString to std::wstring in the following declarations:
- CAdblockPlusClient::IsElementHidden()
- CAdblockPlusClient::ShouldBlock()
- CAdblockPlusClient::m_cacheBlockedSources
- CPluginFilter::IsElementHidden()
- CPluginFilter::ShouldBlock()

The function bodies in CAdblockPlusClient have been converted away from CString,
although those in CPluginFilter have not.

[Oleksandr, 2014-08-21 14:54:30]

LGTM

[Felix Dahlke, 2014-09-30 13:30:15]

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
File src/plugin/AdblockPlusClient.h (right):

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
src/plugin/AdblockPlusClient.h:31: std::map<std::wstring,bool>
m_cacheBlockedSources;
Good time as any to add a space after the comma here.

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
File src/plugin/PluginFilter.cpp (right):

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
src/plugin/PluginFilter.cpp:507: bool CPluginFilter::IsElementHidden(const
std::wstring& tag_wstring, IHTMLElement* pEl, const std::wstring& domain, const
std::wstring& indent) const
Since "CString tag" is temporary and "const std::wstring& tag" is not, we should
IMO give the CString tag a different name rather than change the parameter name.
Same below.

[Eric, 2014-09-30 17:56:40]

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
File src/plugin/AdblockPlusClient.h (right):

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
src/plugin/AdblockPlusClient.h:31: std::map<std::wstring,bool>
m_cacheBlockedSources;
On 2014/09/30 13:30:15, Felix H. Dahlke wrote:
> Good time as any to add a space after the comma here.

Done.

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
File src/plugin/PluginFilter.cpp (right):

http://codereview.adblockplus.org/5163396739629056/diff/5629499534213120/src/...
src/plugin/PluginFilter.cpp:507: bool CPluginFilter::IsElementHidden(const
std::wstring& tag_wstring, IHTMLElement* pEl, const std::wstring& domain, const
std::wstring& indent) const
On 2014/09/30 13:30:15, Felix H. Dahlke wrote:
> Since "CString tag" is temporary and "const std::wstring& tag" is not, we
should
> IMO give the CString tag a different name rather than change the parameter
name.
> Same below.

I was trying to minimize the number of changed lines, but what it really does is
to require changing all those lines at the end of the process rather than the
beginning.

Done.

[Felix Dahlke, 2014-10-01 07:47:28]

LGTM

[sergei, 2014-10-06 10:14:22]

LGTM