Issue 5185987562962944: #240 - Remove carriage return characters (CR/LF => LF)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5185987562962944: #240 - Remove carriage return characters (CR/LF => LF) (Closed)

Created:
Aug. 14, 2014, 7:11 a.m. by mathias

Modified:
Aug. 14, 2014, 1:55 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Stumbled upon this while working on https://issues.adblockplus.org/ticket/240

Patch Set 1 #

Created: Aug. 14, 2014, 7:11 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -35 lines)			Patch
	M	sitescripts/reports/bin/processReports.py	View		2 chunks	+35 lines, -35 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM, but please commit as "Noissue - ...", not under issue 240.

Aug. 14, 2014, 11:25 a.m. (2014-08-14 11:25:06 UTC) #2

mathias

On 2014/08/14 11:25:06, Felix H. Dahlke wrote: > LGTM, but please commit as "Noissue - ...

Aug. 14, 2014, 11:27 a.m. (2014-08-14 11:27:48 UTC) #3

Felix Dahlke

Aug. 14, 2014, 11:36 a.m. (2014-08-14 11:36:35 UTC) #4

On 2014/08/14 11:27:48, matze wrote:
> On 2014/08/14 11:25:06, Felix H. Dahlke wrote:
> > LGTM, but please commit as "Noissue - ...", not under issue 240.
> 
> Sure, but since I do not have any rights for the
> https://hg.adblockplus.org/sitescripts, someone else would have to push that.
Or
> you grant me the respective permissions.. ;)

Commit access in sitescripts definitely makes sense for you, granted.

Expand All Messages | Collapse All Messages