Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5203617959116800: Fixed regression: Context menu clickhide broken (Closed)

Created:
Nov. 28, 2013, 3:08 p.m. by Thomas Greiner
Modified:
Dec. 17, 2013, 3:54 p.m.
Visibility:
Public.

Description

The context menu initiated clickhide was broken due to the introduction of ext.* This review introduces ext.contextMenus and the Chrome implementation of it to fix the regression. There will be a separate review for the Safari implementation due to issues that need to be addressed first.

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M background.js View 1 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/background.js View 1 1 chunk +18 lines, -0 lines 0 comments Download
M safari/background.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Thomas Greiner
Nov. 28, 2013, 3:23 p.m. (2013-11-28 15:23:31 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5203617959116800/diff/5629499534213120/chrome/background.js File chrome/background.js (right): http://codereview.adblockplus.org/5203617959116800/diff/5629499534213120/chrome/background.js#newcode361 chrome/background.js:361: onclick(info, new Tab(tab)); The OnClickData is a rich data ...
Nov. 28, 2013, 11:17 p.m. (2013-11-28 23:17:40 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/5203617959116800/diff/5629499534213120/chrome/background.js File chrome/background.js (right): http://codereview.adblockplus.org/5203617959116800/diff/5629499534213120/chrome/background.js#newcode355 chrome/background.js:355: create: function(title, contexts, onclick) { { should go on ...
Dec. 4, 2013, 3:24 p.m. (2013-12-04 15:24:02 UTC) #3
Thomas Greiner
http://codereview.adblockplus.org/5203617959116800/diff/5629499534213120/chrome/background.js File chrome/background.js (right): http://codereview.adblockplus.org/5203617959116800/diff/5629499534213120/chrome/background.js#newcode355 chrome/background.js:355: create: function(title, contexts, onclick) { On 2013/12/04 15:24:02, Felix ...
Dec. 9, 2013, 4:33 p.m. (2013-12-09 16:33:48 UTC) #4
Wladimir Palant
LGTM
Dec. 16, 2013, 10:38 a.m. (2013-12-16 10:38:23 UTC) #5
Sebastian Noack
LGTM
Dec. 16, 2013, 1:32 p.m. (2013-12-16 13:32:36 UTC) #6
Felix Dahlke
Dec. 17, 2013, 3:39 p.m. (2013-12-17 15:39:51 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld