Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/ui.js

Issue 5292201558933504: Fixed line breaks in notification popup (Closed)
Patch Set: Created Feb. 20, 2014, 1:12 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« chrome/skin/overlay.css ('K') | « chrome/skin/overlay.css ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 1880 matching lines...) Expand 10 before | Expand all | Expand 10 after
1891 if (tagName === "a" && links && links.length) 1891 if (tagName === "a" && links && links.length)
1892 newElement.setAttribute("href", links.shift()); 1892 newElement.setAttribute("href", links.shift());
1893 insertMessage(newElement, value, links); 1893 insertMessage(newElement, value, links);
1894 element.appendChild(newElement); 1894 element.appendChild(newElement);
1895 1895
1896 insertMessage(element, after, links); 1896 insertMessage(element, after, links);
1897 } 1897 }
1898 1898
1899 let texts = Notification.getLocalizedTexts(notification); 1899 let texts = Notification.getLocalizedTexts(notification);
1900 let titleElement = window.document.getElementById("abp-notification-title"); 1900 let titleElement = window.document.getElementById("abp-notification-title");
1901 titleElement.setAttribute("value", texts.title); 1901 titleElement.textContent = texts.title;
1902 let messageElement = window.document.getElementById("abp-notification-messag e"); 1902 let messageElement = window.document.getElementById("abp-notification-messag e");
1903 messageElement.innerHTML = ""; 1903 messageElement.innerHTML = "";
1904 let docLinks = []; 1904 let docLinks = [];
1905 for each (let link in notification.links) 1905 for each (let link in notification.links)
1906 docLinks.push(Utils.getDocLink(link)); 1906 docLinks.push(Utils.getDocLink(link));
1907 insertMessage(messageElement, texts.message, docLinks); 1907 insertMessage(messageElement, texts.message, docLinks);
1908 1908
1909 messageElement.addEventListener("click", function(event) 1909 messageElement.addEventListener("click", function(event)
1910 { 1910 {
1911 let link = event.target; 1911 let link = event.target;
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
1963 ["abp-command-contribute", "command", UI.openContributePage.bind(UI)], 1963 ["abp-command-contribute", "command", UI.openContributePage.bind(UI)],
1964 ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)] 1964 ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)]
1965 ]; 1965 ];
1966 1966
1967 onShutdown.add(function() 1967 onShutdown.add(function()
1968 { 1968 {
1969 for (let window in UI.applicationWindows) 1969 for (let window in UI.applicationWindows)
1970 if (UI.isBottombarOpen(window)) 1970 if (UI.isBottombarOpen(window))
1971 UI.toggleBottombar(window); 1971 UI.toggleBottombar(window);
1972 }); 1972 });
OLDNEW
« chrome/skin/overlay.css ('K') | « chrome/skin/overlay.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld