Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5292201558933504: Fixed line breaks in notification popup (Closed)

Created:
Feb. 20, 2014, 1:12 p.m. by Thomas Greiner
Modified:
Feb. 20, 2014, 1:35 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Fixed line breaks in notification popup

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/skin/overlay.css View 1 chunk +2 lines, -1 line 3 comments Download
M lib/ui.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Felix Dahlke
http://codereview.adblockplus.org/5292201558933504/diff/5629499534213120/chrome/skin/overlay.css File chrome/skin/overlay.css (right): http://codereview.adblockplus.org/5292201558933504/diff/5629499534213120/chrome/skin/overlay.css#newcode209 chrome/skin/overlay.css:209: white-space: nowrap; Isn't this kind of the opposite of ...
Feb. 20, 2014, 1:18 p.m. (2014-02-20 13:18:15 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/5292201558933504/diff/5629499534213120/chrome/skin/overlay.css File chrome/skin/overlay.css (right): http://codereview.adblockplus.org/5292201558933504/diff/5629499534213120/chrome/skin/overlay.css#newcode209 chrome/skin/overlay.css:209: white-space: nowrap; On 2014/02/20 13:18:16, Felix H. Dahlke wrote: ...
Feb. 20, 2014, 1:19 p.m. (2014-02-20 13:19:26 UTC) #2
Felix Dahlke
Feb. 20, 2014, 1:32 p.m. (2014-02-20 13:32:59 UTC) #3
LGTM

http://codereview.adblockplus.org/5292201558933504/diff/5629499534213120/chro...
File chrome/skin/overlay.css (right):

http://codereview.adblockplus.org/5292201558933504/diff/5629499534213120/chro...
chrome/skin/overlay.css:209: white-space: nowrap;
On 2014/02/20 13:19:26, Thomas Greiner wrote:
> On 2014/02/20 13:18:16, Felix H. Dahlke wrote:
> > Isn't this kind of the opposite of what we want? Wouldn't this make any text
> > wider than 300px bleed?
> 
> This only affects the <hbox> element for the Yes/No/Cancel buttons and none of
> the texts.

I see.

Powered by Google App Engine
This is Rietveld