Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5326829724368896: 1521 - libadblockplus is not compilable on linux x64 (Closed)

Created:
Jan. 13, 2015, 3:24 p.m. by paco
Modified:
June 15, 2015, 11:09 a.m.
CC:
mathias, aalvz, sergei
Visibility:
Public.

Description

Since we are not updating the v8 code, we need to ensure that only warnings for that code are ommited, with this change, we will ensure that

Patch Set 1 #

Total comments: 4

Patch Set 2 : '1521 - libadblockplus is not compilable on linux x64' #

Total comments: 6

Patch Set 3 : 1521 - libadblockplus is not compilable on linux x64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M common.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14
paco
Jan. 13, 2015, 3:24 p.m. (2015-01-13 15:24:47 UTC) #1
Felix Dahlke
If this actually fixes the issue, I really don't understand why :D http://codereview.adblockplus.org/5326829724368896/diff/5629499534213120/libadblockplus.gyp File libadblockplus.gyp ...
Jan. 13, 2015, 4:51 p.m. (2015-01-13 16:51:50 UTC) #2
Felix Dahlke
For the record: This seems roughly like what we'll want to do here: https://code.google.com/p/gyp/wiki/GypUserDocumentation#Exclude_settings_on_a_platform
Jan. 13, 2015, 5:03 p.m. (2015-01-13 17:03:55 UTC) #3
paco
Jan. 14, 2015, 3:14 p.m. (2015-01-14 15:14:27 UTC) #4
paco
http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi File common.gypi (left): http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi#oldcode15 common.gypi:15: 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter', Since we're using `-Wall` ...
Jan. 14, 2015, 3:15 p.m. (2015-01-14 15:15:58 UTC) #5
sergei
http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi File common.gypi (right): http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi#newcode16 common.gypi:16: '-std=c++0x', '-fexceptions', ], previously there were spaces.
Jan. 22, 2015, 2:14 p.m. (2015-01-22 14:14:13 UTC) #6
Wladimir Palant
http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi File common.gypi (left): http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi#oldcode15 common.gypi:15: 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter', On 2015/01/14 15:15:58, paco ...
Jan. 22, 2015, 3:29 p.m. (2015-01-22 15:29:21 UTC) #7
paco
> *suppresses* a warning. However, -Wnon-virtual-dtor seems unnecessary indeed. The intention is not supress the ...
Jan. 22, 2015, 3:56 p.m. (2015-01-22 15:56:55 UTC) #8
Felix Dahlke
Sorry for the delay! http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi File common.gypi (left): http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi#oldcode15 common.gypi:15: 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter', ...
Feb. 2, 2015, 2:12 p.m. (2015-02-02 14:12:37 UTC) #9
paco
Feb. 4, 2015, 10:19 a.m. (2015-02-04 10:19:57 UTC) #10
paco
On 2015/02/02 14:12:37, Felix H. Dahlke wrote: > Sorry for the delay! > > http://codereview.adblockplus.org/5326829724368896/diff/5685265389584384/common.gypi ...
Feb. 4, 2015, 10:20 a.m. (2015-02-04 10:20:59 UTC) #11
Felix Dahlke
LGTM
Feb. 4, 2015, 10:41 a.m. (2015-02-04 10:41:11 UTC) #12
Wladimir Palant
LGTM
Feb. 4, 2015, 12:14 p.m. (2015-02-04 12:14:55 UTC) #13
Felix Dahlke
Feb. 26, 2015, 12:47 p.m. (2015-02-26 12:47:53 UTC) #14
Pushed now: https://hg.adblockplus.org/libadblockplus/rev/90e8271246c1

Sorry for the delay, didn't realise I have to push it before you asked, Paco.

Please close review and issue.

Powered by Google App Engine
This is Rietveld