chrome/content/ui/filters-filteractions.js - Issue 5331420155215872: Issue #1129 - Disabling filters via space bar does no longer work

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/ui/filters-filteractions.js

Issue 5331420155215872: Issue #1129 - Disabling filters via space bar does no longer work (Closed)

Patch Set: Created Aug. 6, 2014, 6:21 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/content/ui/filters-filteractions.js

===================================================================

--- a/chrome/content/ui/filters-filteractions.js

+++ b/chrome/content/ui/filters-filteractions.js

@@ -382,7 +382,7 @@

if (event.metaKey)

modifiers |= SubscriptionActions._metaMask;

- if (event.charCode == " ".charCodeAt(0) && modifiers == 0 && !E("col-enabled").hidden)

+ if (event.keyCode == Ci.nsIDOMKeyEvent.DOM_VK_SPACE && modifiers == 0 && !E("col-enabled").hidden)

this.selectionToggleDisabled();

else if (event.keyCode == Ci.nsIDOMKeyEvent.DOM_VK_UP && modifiers == SubscriptionActions._accelMask)

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »