Unified Diff: include/AdblockPlus/V8ValueHolder.h
Issue 5350367445385216:
Fix the crashing (Closed)
Patch Set:
Created July 1, 2014, 10:56 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/V8ValueHolder.h |
| =================================================================== |
| --- a/include/AdblockPlus/V8ValueHolder.h |
| +++ b/include/AdblockPlus/V8ValueHolder.h |
| @@ -51,11 +51,7 @@ |
| } |
| ~V8ValueHolder() |
| { |
| - if (this->value.get()) |
| - { |
| - this->value->Dispose(this->isolate); |
| - this->value.reset(0); |
| - } |
| + reset(isolate, v8::Persistent<T>()); |
|
Wladimir Palant
2014/07/02 09:35:12
I don't get it, with this change the code seems to
|
| } |
| void reset(v8::Isolate* isolate, v8::Persistent<T> value) |
| { |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
