Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5424603463680000: Issue 434 - Added documentation for $sitekey functionality (Closed)

Created:
Sept. 8, 2014, 9:53 a.m. by Thomas Greiner
Modified:
Oct. 15, 2014, 10:35 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 434 - Added documentation for $sitekey functionality

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M body.html View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Sept. 8, 2014, 9:59 a.m. (2014-09-08 09:59:25 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5424603463680000/diff/5629499534213120/body.html File body.html (right): http://codereview.adblockplus.org/5424603463680000/diff/5629499534213120/body.html#newcode162 body.html:162: Sitekey restrictions: The option <code><fix>sitekey=abcdsitekeydcba</fix></code> means that the filter ...
Sept. 8, 2014, 2:09 p.m. (2014-09-08 14:09:26 UTC) #2
Thomas Greiner
http://codereview.adblockplus.org/5424603463680000/diff/5629499534213120/body.html File body.html (right): http://codereview.adblockplus.org/5424603463680000/diff/5629499534213120/body.html#newcode162 body.html:162: Sitekey restrictions: The option <code><fix>sitekey=abcdsitekeydcba</fix></code> means that the filter ...
Sept. 8, 2014, 3:17 p.m. (2014-09-08 15:17:36 UTC) #3
Wladimir Palant
Sept. 9, 2014, 8:50 p.m. (2014-09-09 20:50:46 UTC) #4
LGTM. However, I don't think that applying this makes sense before we actually
release your changes.

Powered by Google App Engine
This is Rietveld