Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5476360696889344: Added SSL encryption to issue tracker configuration (Closed)

Created:
March 11, 2014, 8:58 a.m. by Wladimir Palant
Modified:
March 13, 2014, 6:52 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Added SSL encryption to issue tracker configuration

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M modules/trac/manifests/init.pp View 1 chunk +20 lines, -0 lines 2 comments Download
M modules/trac/templates/site.erb View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
March 11, 2014, 8:58 a.m. (2014-03-11 08:58:34 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5476360696889344/diff/5629499534213120/modules/trac/manifests/init.pp File modules/trac/manifests/init.pp (right): http://codereview.adblockplus.org/5476360696889344/diff/5629499534213120/modules/trac/manifests/init.pp#newcode10 modules/trac/manifests/init.pp:10: file {'/etc/nginx/adblockplus.org_sslcert.key': Note that all other servers have this ...
March 11, 2014, 12:40 p.m. (2014-03-11 12:40:48 UTC) #2
Felix Dahlke
March 13, 2014, 12:32 a.m. (2014-03-13 00:32:16 UTC) #3
LGTM

http://codereview.adblockplus.org/5476360696889344/diff/5629499534213120/modu...
File modules/trac/manifests/init.pp (right):

http://codereview.adblockplus.org/5476360696889344/diff/5629499534213120/modu...
modules/trac/manifests/init.pp:10: file
{'/etc/nginx/adblockplus.org_sslcert.key':
On 2014/03/11 12:40:48, Wladimir Palant wrote:
> Note that all other servers have this file in /etc/nginx/sites-available where
> it doesn't really belong. We should fix it everywhere eventually.

Sounds like an issue that wants to be filed :)

Powered by Google App Engine
This is Rietveld