Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5513912812306432: Issue 1659 - GPL 3 license to our French homepage (Infrastructure) (Closed)

Created:
Dec. 9, 2014, 5:23 p.m. by saroyanm
Modified:
Jan. 7, 2015, 1:13 p.m.
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/1659 Websites: http://codereview.adblockplus.org/6421494749986816/

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M anwiki/_override-static/global/global/css/index.css View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5
saroyanm
Wladimir can you please have a look and also please let me know whether I ...
Dec. 9, 2014, 5:33 p.m. (2014-12-09 17:33:26 UTC) #1
Wladimir Palant
Fine with me, except for the minor nit. http://codereview.adblockplus.org/5513912812306432/diff/5629499534213120/anwiki/_override-static/global/global/css/index.css File anwiki/_override-static/global/global/css/index.css (right): http://codereview.adblockplus.org/5513912812306432/diff/5629499534213120/anwiki/_override-static/global/global/css/index.css#newcode94 anwiki/_override-static/global/global/css/index.css:94: .gpl-license ...
Dec. 9, 2014, 8:34 p.m. (2014-12-09 20:34:11 UTC) #2
saroyanm
http://codereview.adblockplus.org/5513912812306432/diff/5629499534213120/anwiki/_override-static/global/global/css/index.css File anwiki/_override-static/global/global/css/index.css (right): http://codereview.adblockplus.org/5513912812306432/diff/5629499534213120/anwiki/_override-static/global/global/css/index.css#newcode94 anwiki/_override-static/global/global/css/index.css:94: .gpl-license On 2014/12/09 20:34:12, Wladimir Palant wrote: > It ...
Dec. 10, 2014, 6:43 a.m. (2014-12-10 06:43:04 UTC) #3
Thomas Greiner
LGTM
Dec. 10, 2014, 10:16 a.m. (2014-12-10 10:16:22 UTC) #4
Wladimir Palant
Dec. 11, 2014, 5:12 p.m. (2014-12-11 17:12:55 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld