Issue 2462 - New onboarding slides

mobile/android/thirdparty/org/adblockplus/browser/StartPane.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 22 matching lines @@
 import android.view.ViewGroup.LayoutParams;
 import android.view.Window;
 import android.widget.Button;
 import android.widget.LinearLayout;
 import android.widget.TextView;
 
 public class StartPane extends DialogFragment implements OnClickListener, OnKeyListener
 {
   private static final String TAG = "AdblockBrowser.StartPane";
   private int currentStep = 1;
-  private static final int MAXIMUM_STEPS = 3;

[Felix Dahlke, 2015/05/06 07:49:37]

Nit: NUM_STEPS or something rather? We always have the same number, max sounds
more like it could vary and that's the upper limit.

[René Jeschke, 2015/05/06 10:41:56]

Done.

+  private static final int NUMBER_OF_STEPS = 3;
 
   @Override
   public void onCreate(Bundle savedInstanceState)
   {
     super.onCreate(savedInstanceState);
     this.setStyle(DialogFragment.STYLE_NO_TITLE, 0);
   }
 
   @Override
   public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle bundle)
@@ skipping 14 matching lines @@
   {
     super.onActivityCreated(savedInstanceState);
     final Window window = getDialog().getWindow();
     window.setBackgroundDrawable(null);
     window.setLayout(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);
   }
 
   @Override
   public void onClick(View v)
   {
-    if (this.currentStep < MAXIMUM_STEPS)
+    if (this.currentStep < NUMBER_OF_STEPS)
     {
       this.currentStep++;
       this.updateContents(this.getView());
     }
     else
     {
       this.dismissAllowingStateLoss();
     }
   }
 
@@ skipping 35 matching lines @@
     final TextView tv = (TextView) view.findViewById(viewId);
     tv.setText(Html.fromHtml(text));
   }
 
   private void setButtonText(final View view, final int viewId, final int resId)
   {
     final Button button = (Button) view.findViewById(viewId);
     button.setText(this.getString(resId));
   }
 }