Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 5543672087052288: Issue 2462 - New onboarding slides (Closed)

Created:
May 5, 2015, 4:46 p.m. by René Jeschke
Modified:
May 28, 2015, 7:31 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 2462 - New onboarding slides

Patch Set 1 #

Total comments: 4

Patch Set 2 : Renamed MAX_STEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -171 lines) Patch
A mobile/android/base/resources/drawable-hdpi/abb_frp_img_1.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-hdpi/abb_frp_img_2.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-hdpi/abb_frp_img_3.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-ldpi/abb_frp_img_1.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-ldpi/abb_frp_img_2.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-ldpi/abb_frp_img_3.png View Binary file 0 comments Download
D mobile/android/base/resources/drawable-mdpi/abb_community_screenshot.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-mdpi/abb_frp_img_1.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-mdpi/abb_frp_img_2.png View Binary file 0 comments Download
A mobile/android/base/resources/drawable-mdpi/abb_frp_img_3.png View Binary file 0 comments Download
A + mobile/android/base/resources/layout/abb_start_pane_step_1.xml View 1 chunk +11 lines, -6 lines 0 comments Download
A mobile/android/base/resources/layout/abb_start_pane_step_2.xml View 1 chunk +46 lines, -0 lines 0 comments Download
A + mobile/android/base/resources/layout/abb_start_pane_step_3.xml View 1 chunk +11 lines, -6 lines 0 comments Download
D mobile/android/base/resources/layout/abb_start_pane_step_one.xml View 1 chunk +0 lines, -28 lines 0 comments Download
D mobile/android/base/resources/layout/abb_start_pane_step_two.xml View 1 chunk +0 lines, -40 lines 0 comments Download
D mobile/android/base/resources/raw/abb_frp_acceptable_ads.html View 1 chunk +0 lines, -14 lines 0 comments Download
D mobile/android/base/resources/raw/abb_frp_bug_reports.html View 1 chunk +0 lines, -3 lines 0 comments Download
M mobile/android/base/strings.xml.in View 1 chunk +14 lines, -3 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/StartPane.java View 1 7 chunks +12 lines, -71 lines 0 comments Download

Messages

Total messages: 6
René Jeschke
Screenshots: https://www.dropbox.com/s/o6wytlyhrtk62w0/abb_new_frp_1.png?dl=0 https://www.dropbox.com/s/tnmcrdt56c451hg/abb_new_frp_2.png?dl=0 https://www.dropbox.com/s/bnwgsybzk0of1n5/abb_new_frp_3.png?dl=0
May 5, 2015, 4:48 p.m. (2015-05-05 16:48:22 UTC) #1
René Jeschke
Forgot to add a reviewer :-D
May 5, 2015, 5:30 p.m. (2015-05-05 17:30:40 UTC) #2
Felix Dahlke
Looks great, just one nit. http://codereview.adblockplus.org/5543672087052288/diff/5629499534213120/mobile/android/base/strings.xml.in File mobile/android/base/strings.xml.in (right): http://codereview.adblockplus.org/5543672087052288/diff/5629499534213120/mobile/android/base/strings.xml.in#newcode474 mobile/android/base/strings.xml.in:474: <string name="abb_frp_button_1">Two more steps</string> ...
May 6, 2015, 7:49 a.m. (2015-05-06 07:49:37 UTC) #3
Felix Dahlke
Created an issue for this: https://issues.adblockplus.org/ticket/2462
May 6, 2015, 8:46 a.m. (2015-05-06 08:46:16 UTC) #4
René Jeschke
http://codereview.adblockplus.org/5543672087052288/diff/5629499534213120/mobile/android/base/strings.xml.in File mobile/android/base/strings.xml.in (right): http://codereview.adblockplus.org/5543672087052288/diff/5629499534213120/mobile/android/base/strings.xml.in#newcode474 mobile/android/base/strings.xml.in:474: <string name="abb_frp_button_1">Two more steps</string> On 2015/05/06 07:49:37, Felix H. ...
May 6, 2015, 10:41 a.m. (2015-05-06 10:41:56 UTC) #5
Felix Dahlke
May 6, 2015, 10:45 a.m. (2015-05-06 10:45:26 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld