Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5558809044975616: Noissue - Dead code removal (Closed)

Created:
Oct. 2, 2014, 9:57 p.m. by Eric
Modified:
Dec. 31, 2014, 4:33 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke, sergei
Visibility:
Public.

Description

Noissue - Dead code removal Remove a number of miscellaneous unused definitions and some do-nothing code. These changes are mostly Oleksandr's, taken from review http://codereview.adblockplus.org/5948518908821504/

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
M src/plugin/ATL_Deprecate.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/plugin/PluginClass.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/plugin/PluginClass.cpp View 1 3 chunks +10 lines, -18 lines 0 comments Download
M src/plugin/PluginStdAfx.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4
Eric
Oct. 2, 2014, 10 p.m. (2014-10-02 22:00:40 UTC) #1
Oleksandr
http://codereview.adblockplus.org/5558809044975616/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (right): http://codereview.adblockplus.org/5558809044975616/diff/5629499534213120/src/plugin/PluginClass.cpp#newcode1626 src/plugin/PluginClass.cpp:1626: if (client->IsWhitelistedUrl(std::wstring(url))) This should still run only if plugin ...
Oct. 3, 2014, 8:19 a.m. (2014-10-03 08:19:59 UTC) #2
Eric
Removed some no-longer-necessary deprecation pragmas in ATL_Deprecate.h http://codereview.adblockplus.org/5558809044975616/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (right): http://codereview.adblockplus.org/5558809044975616/diff/5629499534213120/src/plugin/PluginClass.cpp#newcode1626 src/plugin/PluginClass.cpp:1626: if (client->IsWhitelistedUrl(std::wstring(url))) ...
Oct. 7, 2014, 3:57 p.m. (2014-10-07 15:57:49 UTC) #3
Oleksandr
Oct. 7, 2014, 5:50 p.m. (2014-10-07 17:50:12 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld