Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5567002995326976: Multiple CMS improvements (Closed)

Created:
Dec. 11, 2013, 10:08 a.m. by Wladimir Palant
Modified:
Dec. 11, 2013, 1:21 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

* Fixed test server reloading * Use unichr() instead of chr() to be Unicode-safe * Allow Markdown in HTML blocks * Allow defining per-repository template filters * Don't convert page-relative links * Don't throw an exception for missing directories (test server only) * Case-insensitive comparison of file extensions * Serve correct MIME type for JPEG images in test server

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M sitescripts/cms/bin/test_server.py View 1 2 chunks +5 lines, -2 lines 0 comments Download
M sitescripts/cms/converters.py View 1 2 chunks +23 lines, -3 lines 0 comments Download
M sitescripts/cms/sources.py View 1 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Dec. 11, 2013, 10:08 a.m. (2013-12-11 10:08:49 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5567002995326976/diff/5629499534213120/sitescripts/cms/converters.py File sitescripts/cms/converters.py (right): http://codereview.adblockplus.org/5567002995326976/diff/5629499534213120/sitescripts/cms/converters.py#newcode186 sitescripts/cms/converters.py:186: if ext != ".py": You might want to compare ...
Dec. 11, 2013, 11:38 a.m. (2013-12-11 11:38:29 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5567002995326976/diff/5629499534213120/sitescripts/cms/converters.py File sitescripts/cms/converters.py (right): http://codereview.adblockplus.org/5567002995326976/diff/5629499534213120/sitescripts/cms/converters.py#newcode186 sitescripts/cms/converters.py:186: if ext != ".py": On 2013/12/11 11:38:29, sebastian wrote: ...
Dec. 11, 2013, 12:05 p.m. (2013-12-11 12:05:19 UTC) #3
Sebastian Noack
Dec. 11, 2013, 12:59 p.m. (2013-12-11 12:59:57 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld