Issue 5636077285015552: Issue 656 - Replace some __proto__ with Object.create

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5636077285015552: Issue 656 - Replace some proto with Object.create (Closed)

Created:
June 23, 2014, 8:46 a.m. by tschuster

Modified:
July 1, 2014, 12:08 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Replace some __proto__ with Object.create

Created: June 23, 2014, 8:46 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -41 lines)			Patch
M	chrome/content/ui/filters-subscriptionview.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/content/ui/sendReport.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/content/ui/sidebar.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/elemHide.js	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	lib/filterClasses.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/filterStorage.js	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/matcher.js	View	6 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/subscriptionClasses.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/sync.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/timeline.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/utils.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2

tschuster

Looks like I never requested review for this. This is really just a search and ...

June 26, 2014, 8:36 p.m. (2014-06-26 20:36:59 UTC) #1

LGTM