Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

include/AdblockPlus/FilterEngine.h

Index: include/AdblockPlus/FilterEngine.h
===================================================================
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -186,11 +186,12 @@
     typedef std::tr1::function<void(const std::string&, const JsValuePtr)> FilterChangeCallback;
 
     /**
-     * Constructor.
+     * Constructor. Allows overloading the prefs

[Felix Dahlke, 2015/06/09 19:40:51]

Nit: Kind of redundant with the parameter description, I'd just leave this part
as it is.

      * @param jsEngine `JsEngine` instance used to run JavaScript code
      *        internally.
+     * @param preconfiguredPrefs `std::map<std::string, std::string>` name-value list of preconfigured Prefs

[Felix Dahlke, 2015/06/09 19:40:51]

Nit: 80 columns? We usually manage to stick to that at least in comments :)
Also, Prefs with a lower case "p", plus a period at the end.

      */
-    explicit FilterEngine(JsEnginePtr jsEngine);
+    explicit FilterEngine(JsEnginePtr jsEngine, std::map<std::string, std::string> preconfiguredPrefs = std::map<std::string, std::string>());

[Felix Dahlke, 2015/06/09 19:40:51]

Nit: Put preconfiguredPrefs on its own line? Probably won't fit on 80 columns
either but it's closer that way. We could probably make things short enough by
using a typedef for the map, but that's up to you.

 
     /**
      * Retrieves the `JsEngine` instance associated with this `FilterEngine`