Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5665210325008384: Combine snapshot classes into a template class (Closed)

Created:
April 3, 2014, 4:51 p.m. by Eric
Modified:
July 18, 2014, 4:43 p.m.
Visibility:
Public.

Description

Combined snapshot classes into a template class

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -138 lines) Patch
M installer/src/custom-action/close_application.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M installer/src/installer-lib/handle.h View 2 chunks +14 lines, -2 lines 0 comments Download
M installer/src/installer-lib/process.h View 10 chunks +182 lines, -73 lines 0 comments Download
M installer/src/installer-lib/process.cpp View 6 chunks +7 lines, -50 lines 0 comments Download
M installer/src/installer-lib/run-tests.cmd View 1 chunk +2 lines, -2 lines 0 comments Download
M installer/src/installer-lib/test/process_test.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M installer/src/installer-lib/test/test-installer-lib-sandbox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Eric
April 3, 2014, 4:53 p.m. (2014-04-03 16:53:19 UTC) #1
Oleksandr
On 2014/04/03 16:53:19, Eric wrote: This can be closed, since it's not the most up ...
July 15, 2014, 2:27 p.m. (2014-07-15 14:27:07 UTC) #2
Eric
July 18, 2014, 4:43 p.m. (2014-07-18 16:43:24 UTC) #3
See review for "Whole installer"
http://codereview.adblockplus.org/6202981292703744/

Powered by Google App Engine
This is Rietveld