Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 5671492293492736: Issue 2611 - Log ABP-Notification-Version response header (Closed)

Created:
June 9, 2015, 12:38 p.m. by Felix Dahlke
Modified:
June 29, 2015, 12:54 p.m.
Reviewers:
mathias
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2611 - Log ABP-Notification-Version resopnse header

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M modules/nginx/manifests/init.pp View 1 chunk +1 line, -0 lines 0 comments Download
M modules/nginx/templates/site.erb View 1 chunk +1 line, -1 line 0 comments Download
M modules/notificationserver/manifests/init.pp View 1 chunk +2 lines, -1 line 0 comments Download
M modules/notificationserver/templates/global.conf.erb View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 5
Felix Dahlke
June 9, 2015, 12:40 p.m. (2015-06-09 12:40:13 UTC) #1
mathias
http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb File modules/notificationserver/templates/global.conf.erb (right): http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb#newcode13 modules/notificationserver/templates/global.conf.erb:13: '$sent_http_abp_notification_version'; What is $sent_http_abp_notification_version?
June 9, 2015, 12:56 p.m. (2015-06-09 12:56:11 UTC) #2
mathias
On 2015/06/09 12:56:11, matze wrote: > http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb > File modules/notificationserver/templates/global.conf.erb (right): > > http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb#newcode13 > ...
June 9, 2015, 12:57 p.m. (2015-06-09 12:57:29 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb File modules/notificationserver/templates/global.conf.erb (right): http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb#newcode13 modules/notificationserver/templates/global.conf.erb:13: '$sent_http_abp_notification_version'; On 2015/06/09 12:56:11, matze wrote: > What is ...
June 9, 2015, 12:58 p.m. (2015-06-09 12:58:40 UTC) #4
mathias
June 9, 2015, 12:59 p.m. (2015-06-09 12:59:47 UTC) #5 
On 2015/06/09 12:58:40, Felix H. Dahlke wrote:
>
http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modu...
> File modules/notificationserver/templates/global.conf.erb (right):
> 
>
http://codereview.adblockplus.org/5671492293492736/diff/5629499534213120/modu...
> modules/notificationserver/templates/global.conf.erb:13:
> '$sent_http_abp_notification_version';
> On 2015/06/09 12:56:11, matze wrote:
> > What is $sent_http_abp_notification_version?
> 
> From: http://nginx.org/en/docs/http/ngx_http_log_module.html
> 
> "Header lines sent to a client have the prefix “sent_http_”, for example,
> $sent_http_content_range."
> 
> The header in question is called "ABP-Notification-Version".

Thank you, LGTM.

Powered by Google App Engine
This is Rietveld