Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5728306397708288: Added definition for eyeo.com webserver (Closed)

Created:
Dec. 4, 2013, 3:58 p.m. by Wladimir Palant
Modified:
Jan. 30, 2014, 12:19 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Added definition for eyeo.com webserver

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -10 lines) Patch
M Vagrantfile View 1 chunk +1 line, -0 lines 0 comments Download
M manifests/monitoringserver.pp View 1 chunk +2 lines, -1 line 0 comments Download
M manifests/nodes.pp View 1 chunk +1 line, -0 lines 0 comments Download
M manifests/vagrant.pp View 1 chunk +1 line, -0 lines 0 comments Download
A manifests/webserver.pp View 1 chunk +8 lines, -0 lines 0 comments Download
M modules/nginx/manifests/init.pp View 1 1 chunk +16 lines, -10 lines 0 comments Download
A modules/web/files/sitescripts View 0 chunks +-1 lines, --1 lines 0 comments Download
A modules/web/manifests/server.pp View 1 1 chunk +72 lines, -0 lines 0 comments Download
A modules/web/templates/site.erb View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Dec. 4, 2013, 3:58 p.m. (2013-12-04 15:58:29 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/5728306397708288/diff/5629499534213120/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): http://codereview.adblockplus.org/5728306397708288/diff/5629499534213120/modules/web/manifests/server.pp#newcode16 modules/web/manifests/server.pp:16: file {'/etc/nginx/sites-enabled/default': The nginx module already has this. http://codereview.adblockplus.org/5728306397708288/diff/5629499534213120/modules/web/manifests/server.pp#newcode21 ...
Dec. 5, 2013, 6:06 a.m. (2013-12-05 06:06:44 UTC) #2
Wladimir Palant
Addressed all review comments. Note that these issues will have to be fixed in nagios ...
Dec. 5, 2013, 9:33 a.m. (2013-12-05 09:33:43 UTC) #3
Felix Dahlke
LGTM
Dec. 10, 2013, 2:24 p.m. (2013-12-10 14:24:46 UTC) #4
Felix Dahlke
Dec. 10, 2013, 2:24 p.m. (2013-12-10 14:24:47 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld