Issue 5749582424178688: Ported over anti-adblock message notification

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5749582424178688: Ported over anti-adblock message notification (Closed)

Created:
Feb. 28, 2014, 6:41 p.m. by Thomas Greiner

Modified:
March 21, 2014, 5:53 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

This issue is a port of the Firefox implementation of the anti-adblock message notification (see http://codereview.adblockplus.org/5538776168267776/). It includes all bug fixes that were necessary for the notification system to work properly again (as discussed in http://codereview.adblockplus.org/6098518317989888/).

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Created: March 21, 2014, 1:29 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -36 lines)			Patch
M	background.js	View	1 2	9 chunks	+58 lines, -22 lines	0 comments	Download
M	chrome/ext/background.js	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	iconAnimation.js	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/prefs.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/utils.js	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	metadata.common	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	notification.html	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	notification.js	View		2 chunks	+24 lines, -4 lines	0 comments	Download
M	webrequest.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

Sorry for the delay, here we go! Looks pretty good all in all, just two ...

March 18, 2014, 2:21 p.m. (2014-03-18 14:21:41 UTC) #2

Thomas Greiner

http://codereview.adblockplus.org/5749582424178688/diff/5629499534213120/background.js File background.js (right): http://codereview.adblockplus.org/5749582424178688/diff/5629499534213120/background.js#newcode255 background.js:255: function initAntiAdblockNotification() On 2014/03/18 14:21:41, Felix H. Dahlke wrote: ...

March 19, 2014, 1:45 p.m. (2014-03-19 13:45:40 UTC) #3

LGTM, sorry for the delays!

Expand All Messages | Collapse All Messages