iconAnimation.js - Issue 5749582424178688: Ported over anti-adblock message notification

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: iconAnimation.js

Issue 5749582424178688: Ported over anti-adblock message notification (Closed)

Patch Set: Created March 21, 2014, 1:29 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: iconAnimation.js

===================================================================

--- a/iconAnimation.js

+++ b/iconAnimation.js

@@ -20,22 +20,22 @@

_animatedTabs: new TabMap(),

_step: 0,

- update: function(severity)

+ update: function(type)

{

- if (severity == this._severity)

+ if (type == this._type)

return;

- if (!this._severity)

+ if (!this._type)

this._start();

- this._severity = severity;

+ this._type = type;

stop: function()

{

clearInterval(this._interval);

delete this._interval;

- delete this._severity;

+ delete this._type;

this._animatedTabs.clear();

@@ -121,7 +121,7 @@

if (this._step > 0)

{

- var suffix = "-notification-" + this._severity;

+ var suffix = "-notification-" + this._type;

if (this._step < 10)

suffix += "-" + this._step;

« no previous file with comments | « chrome/ext/background.js ('k') | lib/prefs.js » ('j') | no next file with comments »