Issue 211 - [trac] Make priority/milestone/component fields visible to everybody

While at it, I allowed regular users to change the CC field - it seems that they can only add or remove themselves.

[Philip Hill, 2014-03-25 11:57:31]

http://codereview.adblockplus.org/5769066073554944/diff/5629499534213120/modu...
File modules/trac/templates/trac.ini.erb (right):

http://codereview.adblockplus.org/5769066073554944/diff/5629499534213120/modu...
modules/trac/templates/trac.ini.erb:276: cc.permission = TICKET_MODIFY
setting cc.permission = TICKET_MODIFY will disallow normal users to edit the cc
field, as they don't have TICKET_MODIFY permissions

[Wladimir Palant, 2014-03-25 12:20:38]

Turns out that for some reason disabling SimpleThemeAdminModule disables
ThemeEngine so that module needs to be kept enabled.

[Wladimir Palant, 2014-03-25 12:23:20]

I fixed a configuration issue that I noticed. Other than that, see my comment
below.

http://codereview.adblockplus.org/5769066073554944/diff/5629499534213120/modu...
File modules/trac/templates/trac.ini.erb (right):

http://codereview.adblockplus.org/5769066073554944/diff/5629499534213120/modu...
modules/trac/templates/trac.ini.erb:276: cc.permission = TICKET_MODIFY
On 2014/03/25 11:57:31, Philip Hill wrote:
> setting cc.permission = TICKET_MODIFY will disallow normal users to edit the
cc
> field, as they don't have TICKET_MODIFY permissions

You are right, registered users in our instance don't have TICKET_MODIFY
privilege - my test instance had outdated permissions. We might want to consider
giving them that permission and making sure that fields like "ready" and
"inprogress" require an advanced privilege instead. For now this seems fine as
it is.

[Philip Hill, 2014-03-25 13:24:51]

On 2014/03/25 12:23:20, Wladimir Palant wrote:
> I fixed a configuration issue that I noticed. Other than that, see my comment
> below.
> 
>
http://codereview.adblockplus.org/5769066073554944/diff/5629499534213120/modu...
> File modules/trac/templates/trac.ini.erb (right):
> 
>
http://codereview.adblockplus.org/5769066073554944/diff/5629499534213120/modu...
> modules/trac/templates/trac.ini.erb:276: cc.permission = TICKET_MODIFY
> On 2014/03/25 11:57:31, Philip Hill wrote:
> > setting cc.permission = TICKET_MODIFY will disallow normal users to edit the
> cc
> > field, as they don't have TICKET_MODIFY permissions
> 
> You are right, registered users in our instance don't have TICKET_MODIFY
> privilege - my test instance had outdated permissions. We might want to
consider
> giving them that permission and making sure that fields like "ready" and
> "inprogress" require an advanced privilege instead. For now this seems fine as
> it is.

As far as my lacking CSS knowledge can state, everything looks good now.

[Wladimir Palant, 2014-03-25 15:41:53]

Uploaded new patchset - "Review URL(s)" field is visible again but grayed out
because hiding the wiki toolbar via CSS doesn't seem possible. Also added a
missing Puppet dependency.

[Philip Hill, 2014-03-25 16:07:12]

On 2014/03/25 15:41:53, Wladimir Palant wrote:
> Uploaded new patchset - "Review URL(s)" field is visible again but grayed out
> because hiding the wiki toolbar via CSS doesn't seem possible. Also added a
> missing Puppet dependency.

LGTM