Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5778562212691968: Added redirects for legacy URLs to eyeo.com configuration and added host name aliases (Closed)

Created:
Jan. 14, 2014, 10:41 a.m. by Wladimir Palant
Modified:
Jan. 30, 2014, 2:08 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Added redirects for legacy URLs to eyeo.com configuration and added host name aliases

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -8 lines) Patch
M manifests/webserver.pp View 1 chunk +12 lines, -1 line 0 comments Download
M modules/web/manifests/server.pp View 1 chunk +7 lines, -1 line 0 comments Download
M modules/web/templates/site.erb View 2 chunks +44 lines, -6 lines 1 comment Download

Messages

Total messages: 3
Wladimir Palant
Jan. 14, 2014, 10:42 a.m. (2014-01-14 10:42:05 UTC) #1
Wladimir Palant
Given that the other two eyeo.com reviews have been waiting for a while already, I ...
Jan. 14, 2014, 11:10 a.m. (2014-01-14 11:10:37 UTC) #2
Felix Dahlke
Jan. 30, 2014, 1:56 p.m. (2014-01-30 13:56:08 UTC) #3
LGTM

http://codereview.adblockplus.org/5778562212691968/diff/5629499534213120/modu...
File modules/web/templates/site.erb (right):

http://codereview.adblockplus.org/5778562212691968/diff/5629499534213120/modu...
modules/web/templates/site.erb:7: listen 80;
Ah, now I see where this came from for filterserver/notificationserver :)

I guess it does make sense to make one server the default server.

Powered by Google App Engine
This is Rietveld