Issue 5809357497303040: Notification 'x' button in popup fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5809357497303040: Notification 'x' button in popup fix (Closed)

Created:
Feb. 22, 2014, 5:17 p.m. by saroyanm

Modified:
Feb. 25, 2014, 12:40 p.m.

Reviewers:
Thomas Greiner, Felix Dahlke

Visibility:
Public.

Description

This issue is related to current ticket: https://trello.com/c/2JexnYDW/367-quick-fix-x-in-icon-popup-notification-box-doesn-t-close-notification

Patch Set 1 #

Created: Feb. 22, 2014, 5:17 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	notification.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM, although we typically set useCapture to false for reasons I'm not entirely sure about. ...

Feb. 24, 2014, 12:49 p.m. (2014-02-24 12:49:02 UTC) #1

Thomas Greiner

On 2014/02/24 12:49:02, Felix H. Dahlke wrote: > LGTM, although we typically set useCapture to ...

Feb. 25, 2014, 11:19 a.m. (2014-02-25 11:19:14 UTC) #2

saroyanm

Feb. 25, 2014, 12:40 p.m. (2014-02-25 12:40:47 UTC) #3

On 2014/02/25 11:19:14, Thomas Greiner wrote:
> On 2014/02/24 12:49:02, Felix H. Dahlke wrote:
> > LGTM, although we typically set useCapture to false for reasons I'm not
> entirely
> > sure about. Thomas?
> 
> LGTM but please add the useCapture parameter to the addEventListener function
as
> Felix suggested. We usually add it to clarify what the event listener
captures.
> 
> We may need to revisit this depending on how
> http://codereview.adblockplus.org/6098518317989888/ turns out.

Commited changes, updated useCapture parameter for the Element and for window
Onload listener.

Expand All Messages | Collapse All Messages