Set the branding via confvars.sh

Set the branding via confvars.sh

[Felix Dahlke, 2015-01-26 15:13:12]

I realised we can set the branding to use in confvars.sh rather than in
.mozconfig.

[René Jeschke, 2015-02-18 14:52:29]

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
File README.md (right):

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
README.md:9: Follow Mozilla's
Is this newline really needed here?

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/mobi...
File mobile/android/confvars.sh (right):

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/mobi...
mobile/android/confvars.sh:11:
MOZ_BRANDING_DIRECTORY=mobile/android/branding/adblockbrowser
The ABP branding isn't in the repository yet, did I already reviewed this?

[Felix Dahlke, 2015-02-18 15:02:28]

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
File README.md (right):

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
README.md:9: Follow Mozilla's
On 2015/02/18 14:52:30, René Jeschke wrote:
> Is this newline really needed here?

Yeah, to stick to 80 columns, I'm usually putting long links on their own line.
Haven't really found a better way yet, I'd rather not have super long lines just
because of the links. Would be brilliant if we could have links at the bottom as
on StackOverflow...

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/mobi...
File mobile/android/confvars.sh (right):

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/mobi...
mobile/android/confvars.sh:11:
MOZ_BRANDING_DIRECTORY=mobile/android/branding/adblockbrowser
On 2015/02/18 14:52:30, René Jeschke wrote:
> The ABP branding isn't in the repository yet, did I already reviewed this?

Yup, this is based on: http://codereview.adblockplus.org/6349873972510720/

In a nutshell: We don't have to mess with .mozconfig anymore, we can just follow
the official build guide. I'm mildly worried about that one getting out of sync
with our version, but that's a different problem.

[René Jeschke, 2015-02-18 15:07:26]

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
File README.md (right):

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
README.md:9: Follow Mozilla's
On 2015/02/18 15:02:28, Felix H. Dahlke wrote:
> On 2015/02/18 14:52:30, René Jeschke wrote:
> > Is this newline really needed here?
> 
> Yeah, to stick to 80 columns, I'm usually putting long links on their own
line.
> Haven't really found a better way yet, I'd rather not have super long lines
just
> because of the links. Would be brilliant if we could have links at the bottom
as
> on StackOverflow...

How about:
Follow Mozilla's [Building Fennec][] guide.

... more text here

[Building Fennec]: https://wiki.mozilla.org/Mobile/Fennec/Android

Works on github and is markdown conform.

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/mobi...
File mobile/android/confvars.sh (right):

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/mobi...
mobile/android/confvars.sh:11:
MOZ_BRANDING_DIRECTORY=mobile/android/branding/adblockbrowser
On 2015/02/18 15:02:28, Felix H. Dahlke wrote:
> On 2015/02/18 14:52:30, René Jeschke wrote:
> > The ABP branding isn't in the repository yet, did I already reviewed this?
> 
> Yup, this is based on: http://codereview.adblockplus.org/6349873972510720/
> 
> In a nutshell: We don't have to mess with .mozconfig anymore, we can just
follow
> the official build guide. I'm mildly worried about that one getting out of
sync
> with our version, but that's a different problem.

Ah, right :-D thanks

[Felix Dahlke, 2015-02-18 15:14:42]

New patch set up.

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
File README.md (right):

http://codereview.adblockplus.org/5823470080360448/diff/5649050225344512/READ...
README.md:9: Follow Mozilla's
On 2015/02/18 15:07:26, René Jeschke wrote:
> On 2015/02/18 15:02:28, Felix H. Dahlke wrote:
> > On 2015/02/18 14:52:30, René Jeschke wrote:
> > > Is this newline really needed here?
> > 
> > Yeah, to stick to 80 columns, I'm usually putting long links on their own
> line.
> > Haven't really found a better way yet, I'd rather not have super long lines
> just
> > because of the links. Would be brilliant if we could have links at the
bottom
> as
> > on StackOverflow...
> 
> How about:
> Follow Mozilla's [Building Fennec][] guide.
> 
> ... more text here
> 
> [Building Fennec]: https://wiki.mozilla.org/Mobile/Fennec/Android
> 
> Works on github and is markdown conform.

Done. Wasn't aware that's possible, woohoo :D

[René Jeschke, 2015-02-18 15:16:11]

LGTM