Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5978545083908096: Relocating sharing section (Closed)

Created:
Nov. 8, 2013, 5:07 p.m. by sven
Modified:
Dec. 2, 2013, 4:41 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Relocating sharing section

Patch Set 1 : #

Total comments: 5

Patch Set 2 : deleted unnecessary translations #

Total comments: 1

Patch Set 3 : added line break to firstRun.properties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -253 lines) Patch
M chrome/content/ui/firstRun.html View 2 chunks +32 lines, -56 lines 0 comments Download
M chrome/content/ui/firstRun.js View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/locale/en-US/firstRun.properties View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/skin/firstRun.css View 8 chunks +12 lines, -186 lines 0 comments Download

Messages

Total messages: 7
sven
Nov. 8, 2013, 5:16 p.m. (2013-11-08 17:16:01 UTC) #1
Thomas Greiner
Make sure to also remove images and strings that are no longer needed. http://codereview.adblockplus.org/5978545083908096/diff/5668600916475904/chrome/content/ui/firstRun.html File ...
Nov. 11, 2013, 2:08 p.m. (2013-11-11 14:08:37 UTC) #2
sven
Nov. 11, 2013, 6:19 p.m. (2013-11-11 18:19:45 UTC) #3
sven
Nov. 15, 2013, 11:50 a.m. (2013-11-15 11:50:01 UTC) #4
Thomas Greiner
http://codereview.adblockplus.org/5978545083908096/diff/5733935958982656/chrome/locale/en-US/firstRun.properties File chrome/locale/en-US/firstRun.properties (right): http://codereview.adblockplus.org/5978545083908096/diff/5733935958982656/chrome/locale/en-US/firstRun.properties#newcode23 chrome/locale/en-US/firstRun.properties:23: firstRun_contributor_credits=Contributor Credits End the file with a newline (make ...
Nov. 19, 2013, 3:05 p.m. (2013-11-19 15:05:07 UTC) #5
sven
Nov. 29, 2013, 9:53 a.m. (2013-11-29 09:53:32 UTC) #6
Thomas Greiner
Nov. 29, 2013, 10:05 a.m. (2013-11-29 10:05:44 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld