Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5989262990245888: Use default localisations for WiX dialogs (Closed)

Created:
April 29, 2014, 2:01 a.m. by Oleksandr
Modified:
May 23, 2014, 8:57 a.m.
Reviewers:
Eric, Wladimir Palant
Visibility:
Public.

Description

Use default localisations for WiX dialogs

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -110 lines) Patch
M installer/installer.gyp View 13 chunks +29 lines, -106 lines 0 comments Download
M installer/msibuild.cmd View 2 chunks +11 lines, -3 lines 0 comments Download
M installer/src/msi/adblockplusie.wxs View 1 chunk +1 line, -1 line 1 comment Download
A installer/src/msi/locale/ar-SA.wxl View 1 chunk +23 lines, -0 lines 0 comments Download
A installer/src/msi/locale/de-DE.wxl View 1 chunk +21 lines, -0 lines 0 comments Download
A installer/src/msi/locale/fr-FR.wxl View 1 chunk +22 lines, -0 lines 0 comments Download
A installer/src/msi/locale/it-IT.wxl View 1 chunk +22 lines, -0 lines 0 comments Download
A installer/src/msi/locale/nl-NL.wxl View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Oleksandr
April 29, 2014, 2:03 a.m. (2014-04-29 02:03:13 UTC) #1
Eric
May 1, 2014, 2:46 p.m. (2014-05-01 14:46:20 UTC) #2
LGTM.

The zh-TW issue isn't a blocker, but I'm curious about it.

http://codereview.adblockplus.org/5989262990245888/diff/5629499534213120/inst...
File installer/src/msi/adblockplusie.wxs (left):

http://codereview.adblockplus.org/5989262990245888/diff/5629499534213120/inst...
installer/src/msi/adblockplusie.wxs:115:
Languages="7,1,9,12,16,19,1026,1027,1028,1029,1030,1032,1034,1035,1037,1038,1041,1044,1045,1046,1048,1049,1050,1051,1053,1054,1055,1058,1061,1081,2052,2070"
Good catch removing 1081 (hi-IN). I hadn't included the other IN languages, but
I missed that one.

Removing 1028 (zh-TW, Chinese - Taiwan) puzzles me, though. We have an MSI for
it, and WiX has UI localization for it. Our zh-TW.wxl has been localized to
Chinese characters (I think traditional ones), even if zh-CN.wxl (Chinese -
China PRC) hasn't been.

Is there some other issue I'm not aware of?

Powered by Google App Engine
This is Rietveld