Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6000668259123200: Remove ext.browserAction.show/hide (Closed)

Created:
Dec. 17, 2013, 3:31 p.m. by Thomas Greiner
Modified:
Dec. 17, 2013, 3:58 p.m.
Visibility:
Public.

Description

A browser action cannot be shown/hidden so we can get rid of that functionality and of the related setting shouldShowIcon. Users who want to hide the icon can still do so through the browser.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M background.js View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/background.js View 1 chunk +0 lines, -8 lines 0 comments Download
M options.html View 1 chunk +0 lines, -3 lines 0 comments Download
M options.js View 1 chunk +0 lines, -1 line 0 comments Download
M safari/background.js View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3
Thomas Greiner
Dec. 17, 2013, 3:34 p.m. (2013-12-17 15:34:14 UTC) #1
Wladimir Palant
LGTM if you remove the corresponding strings from messages.json as well.
Dec. 17, 2013, 3:36 p.m. (2013-12-17 15:36:57 UTC) #2
Felix Dahlke
Dec. 17, 2013, 3:58 p.m. (2013-12-17 15:58:22 UTC) #3
LGTM with Wladimir's issue addressed.

Powered by Google App Engine
This is Rietveld