Noissue - Upgraded to latest libadblockplus version, included v8 includes

Noissue - Upgraded to latest libadblockplus version, included v8 includes

[René Jeschke, 2015-01-29 14:40:40]

Upgraded to latest binaries.

For the v8 includes:

Currently we have them in adblockplusandroid/jni/v8, which is not the correct
location IMO. v8 is so tightly bound to libadblockplus (which we include using
the libadblockplus-binaries repository) that the logical next step is: including
the v8 includes here, too.

Follow up code-review for removal of the files from v8 is coming as soon as the
libadblockplus-binaries repository is updated.

[René Jeschke, 2015-01-29 14:41:41]

On 2015/01/29 14:40:40, René Jeschke wrote:
> Upgraded to latest binaries.
> 
> For the v8 includes:
> 
> Currently we have them in adblockplusandroid/jni/v8, which is not the correct
> location IMO. v8 is so tightly bound to libadblockplus (which we include using
> the libadblockplus-binaries repository) that the logical next step is:
including
> the v8 includes here, too.
> 
> Follow up code-review for removal of the files from v8 is coming as soon as
the
> libadblockplus-binaries repository is updated.

Removal of the files from 'adblockplusandroid/jni', of course.

[Felix Dahlke, 2015-01-29 16:54:16]

Can you try to upload the patch set again? Something might have gone wrong, says
"Upload in progress" to me.

On 2015/01/29 14:40:40, René Jeschke wrote:
> Upgraded to latest binaries.
> 
> For the v8 includes:
> 
> Currently we have them in adblockplusandroid/jni/v8, which is not the correct
> location IMO. v8 is so tightly bound to libadblockplus (which we include using
> the libadblockplus-binaries repository) that the logical next step is:
including
> the v8 includes here, too.
> 
> Follow up code-review for removal of the files from v8 is coming as soon as
the
> libadblockplus-binaries repository is updated.

Well, if we actually need the v8 includes here, yeah, makes sense to have them
here.

[Felix Dahlke, 2015-01-29 16:56:04]

> On 2015/01/29 14:40:40, René Jeschke wrote:
> > Upgraded to latest binaries.
> > 
> > For the v8 includes:
> > 
> > Currently we have them in adblockplusandroid/jni/v8, which is not the
correct
> > location IMO. v8 is so tightly bound to libadblockplus (which we include
using
> > the libadblockplus-binaries repository) that the logical next step is:
> including
> > the v8 includes here, too.
> > 
> > Follow up code-review for removal of the files from v8 is coming as soon as
> the
> > libadblockplus-binaries repository is updated.
> 
> Well, if we actually need the v8 includes here, yeah, makes sense to have them
> here.

IIRC, and how I remember it, we don't actually NEED the v8 includes in
libadblockplus clients. So we should just be able to get rid of them in
adblockplusandroid.

[René Jeschke, 2015-01-29 17:10:15]

On 2015/01/29 16:56:04, Felix H. Dahlke wrote:
> > On 2015/01/29 14:40:40, René Jeschke wrote:
> > > Upgraded to latest binaries.
> > > 
> > > For the v8 includes:
> > > 
> > > Currently we have them in adblockplusandroid/jni/v8, which is not the
> correct
> > > location IMO. v8 is so tightly bound to libadblockplus (which we include
> using
> > > the libadblockplus-binaries repository) that the logical next step is:
> > including
> > > the v8 includes here, too.
> > > 
> > > Follow up code-review for removal of the files from v8 is coming as soon
as
> > the
> > > libadblockplus-binaries repository is updated.
> > 
> > Well, if we actually need the v8 includes here, yeah, makes sense to have
them
> > here.
> 
> IIRC, and how I remember it, we don't actually NEED the v8 includes in
> libadblockplus clients. So we should just be able to get rid of them in
> adblockplusandroid.

K, done.

[Felix Dahlke, 2015-01-29 17:35:24]

LGTM

http://codereview.adblockplus.org/6090724420354048/diff/5685265389584384/incl...
File include/AdblockPlus.h (right):

http://codereview.adblockplus.org/6090724420354048/diff/5685265389584384/incl...
include/AdblockPlus.h:44: #include "AdblockPlus/Notification.h"
Grmbl, just realised this is not using angle brackets, while it should. Well,
that needs fixing in libadblockplus.