Issue 6219285298937856: Issue 468 - Update to Trac Account Manager 0.4.4

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6219285298937856: Issue 468 - Update to Trac Account Manager 0.4.4 (Closed)

Created:
May 12, 2014, 9:47 a.m. by Wladimir Palant

Modified:
May 12, 2014, 10:12 a.m.

Reviewers:
Philip Hill

Visibility:
Public.

Description

Issue 468 - Update to Trac Account Manager 0.4.4

Patch Set 1 #

Total comments: 1

Created: May 12, 2014, 9:47 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	modules/trac/manifests/init.pp	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Philip Hill

May 12, 2014, 10:10 a.m. (2014-05-12 10:10:28 UTC) #2

Despite the comment, LGTM

http://codereview.adblockplus.org/6219285298937856/diff/5629499534213120/modu...
File modules/trac/manifests/init.pp (right):

http://codereview.adblockplus.org/6219285298937856/diff/5629499534213120/modu...
modules/trac/manifests/init.pp:74: command => "pip install
svn+http://trac-hacks.org/svn/accountmanagerplugin/tags/acct_mgr-0.4.4/",
Provisioning will not do it with that change, as unless => "python -c 'import
acct_mgr'", will be true. However, there seems to be no way to check the
installed plugin's version from console.

Expand All Messages | Collapse All Messages