Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6234732039766016: Improve installer build instructions (Closed)

Created:
July 24, 2014, 8:42 a.m. by Felix Dahlke
Modified:
July 24, 2014, 9:54 a.m.
Reviewers:
Oleksandr
Visibility:
Public.

Description

Improve installer build instructions - Add prerequisites - Use code formatting consistently - Wrap at 80 columns

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a remark about WiX in %PATH%, make things more consistent #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M README.md View 1 1 chunk +15 lines, -10 lines 1 comment Download

Messages

Total messages: 4
Felix Dahlke
July 24, 2014, 8:44 a.m. (2014-07-24 08:44:22 UTC) #1
Oleksandr
LGTM http://codereview.adblockplus.org/6234732039766016/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/6234732039766016/diff/5629499534213120/README.md#newcode30 README.md:30: [InnoSetup 5.5](http://www.jrsoftware.org/isinfo.php). Also you'll have to add |WiX ...
July 24, 2014, 9:21 a.m. (2014-07-24 09:21:09 UTC) #2
Felix Dahlke
Done, also did some other improvements to that section while we're at it. Currently waiting ...
July 24, 2014, 9:29 a.m. (2014-07-24 09:29:48 UTC) #3
Oleksandr
July 24, 2014, 9:48 a.m. (2014-07-24 09:48:35 UTC) #4
LGTM

http://codereview.adblockplus.org/6234732039766016/diff/5105650963054592/READ...
File README.md (right):

http://codereview.adblockplus.org/6234732039766016/diff/5105650963054592/READ...
README.md:40: Developer Command Prompt.
or you can use a makefile and run nmake from Visual Studio command prompt:

nmake ia32
and
nmake x64

The third possible option for the makefile (nmake setup) needs to be adjusted to
use InnoSetup instead of burn now. I've created an issue for that:
https://issues.adblockplus.org/ticket/1132

Powered by Google App Engine
This is Rietveld