Issue 6252349005758464: Never show the home banner

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6252349005758464: Never show the home banner (Closed)

Created:
Dec. 24, 2014, 7:48 a.m. by Felix Dahlke

Modified:
May 21, 2015, 11:57 a.m.

Reviewers:
René Jeschke

CC:
Wladimir Palant

Visibility:
Public.

Description

Never show the home banner In the prototype I kept the home banner from showing up with a more intrusive code change, but wasn't happy with that. This approach will still load the home banner, and actually show it if there are any snippets. But I've changed some prefs to ensure there aren't any. There are basically two types of snippets: 1. First run and sync promo snippet - these are shipped with the app. 2. Snippets fetched from snippets.mozilla.com - setting browser.snippets.enabled to false as I did keeps us from fetching these.

Patch Set 1 #

Patch Set 2 : Remove the comment - less intrusive change, and obvious enough #

Created: Dec. 24, 2014, 7:59 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	mobile/android/app/mobile.js	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages