Issue 6266581101314048: WIP: Have one global element hide stylesheet and inject the other ones per site

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6266581101314048: WIP: Have one global element hide stylesheet and inject the other ones per site (Closed)

Created:
July 27, 2014, 11:45 a.m. by tschuster

Modified:
Jan. 19, 2015, 9:59 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

This still has tons of issues, but the result seems quite good. In about:memory under window-object > layout > style-sets I see memory reduction of about ~50%. It would be awesome if somebody could verify these results. There is still some issue that are left to resolve: - We shouldn't write the per domain style-sheets into a file, but I couldn't get data URIs to work - Handle rule removal - Measure the memory/performance impact of filterByDomain

Patch Set 1 #

Patch Set 2 : rebased #

Created: Aug. 19, 2014, 12:15 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -4 lines)			Patch
	M	lib/elemHide.js	View	1	4 chunks	+57 lines, -4 lines	0 comments	Download
	M	lib/elemHideHitRegistration.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

tschuster

Aug. 19, 2014, 12:15 p.m. (2014-08-19 12:15:45 UTC) #1

Hey after you review my other page, it would be cool if you took a look at this
patch

Expand All Messages | Collapse All Messages