Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6330493855334400: Issue 2155 - Ensure /etc/puppet/hiera.yaml is linked properly (Closed)

Created:
March 17, 2015, 9:24 a.m. by mathias
Modified:
March 17, 2015, 9:41 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/2155

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M hiera/install_precise.py View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 3
mathias
March 17, 2015, 9:24 a.m. (2015-03-17 09:24:41 UTC) #1
Felix Dahlke
LGTM http://codereview.adblockplus.org/6330493855334400/diff/5629499534213120/hiera/install_precise.py File hiera/install_precise.py (right): http://codereview.adblockplus.org/6330493855334400/diff/5629499534213120/hiera/install_precise.py#newcode101 hiera/install_precise.py:101: realpath = os.path.realpath(__file__) Trailing slash, huh? :)
March 17, 2015, 9:33 a.m. (2015-03-17 09:33:50 UTC) #2
mathias
March 17, 2015, 9:41 a.m. (2015-03-17 09:41:00 UTC) #3
http://codereview.adblockplus.org/6330493855334400/diff/5629499534213120/hier...
File hiera/install_precise.py (right):

http://codereview.adblockplus.org/6330493855334400/diff/5629499534213120/hier...
hiera/install_precise.py:101: realpath = os.path.realpath(__file__)
On 2015/03/17 09:33:50, Felix H. Dahlke wrote:
> Trailing slash, huh? :)

Indeed :)

Powered by Google App Engine
This is Rietveld