Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6334977742471168: Missing JS Shell in Mozilla v20 build (Closed)

Created:
Feb. 11, 2014, 4:35 p.m. by saroyanm
Modified:
Feb. 24, 2014, 10:37 a.m.
Visibility:
Public.

Description

Mozilla removed JS shell from it's server (Mozilla FF V20.0-candidates), the one we were using during the build of our project. I was trying to use the new ones as Wladimir suggested (Mozilla FF v27), but without success, because the new versions of JS shell (above v20) parsing our script the way different so jshydra unable to run. example: jshydra.js line 43: arguments are not been able to be passed after running abp_rewrite.py. and also some other function that seams like to be changed or not exist in current JS shell. The current patch is pointing to v17 Mozilla build and seams to work Okey. Actually what I suggest is to host v20 JS shell build on ABP servers, I do not have the files, but if you still have them, then we can figure out to host on ABP servers. You can find the js shield in current directory -> "[projectdir]/buildtools/jshydra/mozilla" Note: In future we have risk that the files will be removed again from Mozilla servers.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
LGTM as a stopgap solution, we will need to figure out something better for the ...
Feb. 22, 2014, 9:13 a.m. (2014-02-22 09:13:56 UTC) #1
saroyanm
Feb. 24, 2014, 10:37 a.m. (2014-02-24 10:37:19 UTC) #2
On 2014/02/22 09:13:56, Wladimir Palant wrote:
> LGTM as a stopgap solution, we will need to figure out something better for
the
> future.

Good point, stopgap commited.

Powered by Google App Engine
This is Rietveld