Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6336691434422272: Added unit tests for URL-specific notifications (Closed)

Created:
Feb. 19, 2014, 1:01 p.m. by Thomas Greiner
Modified:
Feb. 20, 2014, 9:42 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This issue includes the following changes from the adblockplus repository: - added URL-specific notifications - changed "severity" to "type" - allow messages without localization

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -9 lines) Patch
M chrome/content/tests/notification.js View 8 chunks +75 lines, -9 lines 0 comments Download

Messages

Total messages: 2
Thomas Greiner
Feb. 19, 2014, 1:03 p.m. (2014-02-19 13:03:35 UTC) #1
Felix Dahlke
Feb. 19, 2014, 1:14 p.m. (2014-02-19 13:14:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld